Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-30458 Parquet plugin needs timestamp support #17890

Merged
merged 1 commit into from
Oct 13, 2023
Merged

HPCC-30458 Parquet plugin needs timestamp support #17890

merged 1 commit into from
Oct 13, 2023

Conversation

jackdelv
Copy link
Contributor

@jackdelv jackdelv commented Oct 11, 2023 •
edited
Loading

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@github-actions
Copy link

https://track.hpccsystems.com/browse/HPCC-30458
Jira updated

ghalliday
ghalliday reviewed Oct 11, 2023
View reviewed changes
Copy link
Member

@ghalliday ghalliday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jackdelv I'm not sure about the efficiency of going via text for most of the field types. These look like fairly low level routines that will be called a lot.

@jackdelv jackdelv force-pushed the HPCC-30458 branch 2 times, most recently from 897e47f to da57f90 Compare October 11, 2023 18:00
@jackdelv jackdelv requested a review from ghalliday October 11, 2023 18:02
@jackdelv
Copy link
Contributor Author

@ghalliday I agree that it was inefficient to go through text for every type. Now it only happens if we are converting data stored in text to other types.

ghalliday
ghalliday reviewed Oct 12, 2023
View reviewed changes
Copy link
Member

@ghalliday ghalliday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor comments, but looks close to ready.

plugins/parquet/parquetembed.cpp Outdated
}
}

__int64 ParquetRowBuilder::getCurrValue(const RtlFieldInfo *field)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

possible getCurrIntValue() to make it clear what kind of value it is returning

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed.

plugins/parquet/parquetembed.cpp Outdated
return getSigned(array_visitor, currArrayIndex());
case UIntType:
return getUnsigned(array_visitor, currArrayIndex());
case DoubleType:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential for a getReal() function similar to getSigned/unsigned which returned values for Double/HalfFloat/Float which is also called from getRealResult()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a getReal() function and removed extra types. Added getReal to getCurrIntValue() and getRealResult().

@jackdelv jackdelv requested a review from ghalliday October 12, 2023 12:18
ghalliday
ghalliday approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@ghalliday ghalliday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the further cleanup, switching to use the size.

plugins/parquet/parquetembed.cpp
@@ -872,6 +872,21 @@ unsigned __int64 getUnsigned(std::shared_ptr<ParquetArrayVisitor> *array_visitor
}
}

double getReal(std::shared_ptr<ParquetArrayVisitor> *array_visitor, int index)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: These functions could be static (to avoid the function names being exported globally). Don't change for this PR though.

plugins/parquet/parquetembed.cpp
if ((*array_visitor)->type == RealType)
return getReal(array_visitor, currArrayIndex());
else
return getCurrIntValue(field);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strings will not be converted to real values. However I would be tempted to create a separate PR to fix that and merge this one as-is.

jakesmith
jakesmith approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@jakesmith jakesmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jackdelv 1 question, but looks good.

plugins/parquet/parquetembed.hpp
arrow::Status Visit(const arrow::TimestampArray &array)
{
timestamp_arr = &array;
type = TimestampType;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it okay to leave size=0 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the size only gets used for the Signed, Unsigned, and Real types to differentiate between the different variations of each that can be stored in parquet.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the size only gets used for the Signed, Unsigned, and Real types to differentiate between the different variations of each that can be stored in parquet.

@ghalliday
Copy link
Member

@jackdelv please squash

@ghalliday ghalliday merged commit 4944f9c into hpcc-systems:candidate-9.4.x Oct 13, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakesmith jakesmith jakesmith approved these changes

@ghalliday ghalliday ghalliday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jackdelv @ghalliday @jakesmith