Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-30419 Add url-secret-name to ecl usage #17857

Merged
merged 1 commit into from
Oct 5, 2023
Merged

HPCC-30419 Add url-secret-name to ecl usage #17857

merged 1 commit into from
Oct 5, 2023

Conversation

jakesmith
Copy link
Member

@jakesmith jakesmith commented Oct 3, 2023 •
edited
Loading

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@jakesmith jakesmith requested a review from afishbeck October 3, 2023 15:09
@github-actions
Copy link

github-actions bot commented Oct 3, 2023

https://track.hpccsystems.com/browse/HPCC-30419
Jira updated

afishbeck
afishbeck requested changes Oct 3, 2023
View reviewed changes
Copy link
Member

@afishbeck afishbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great just missing newline.

ecl/eclcmd/eclcmd_shell.cpp Outdated
" zapgen provide ZAP file from WUID\n"
" sign add digital signature to an ecl file or a text file\n"
" listkeyuid lists all the key user IDs that can be used in the sign command\n"
" url-secret-name Generate a secret name from a url for automatic url mapping"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jakesmith Looks great, but missing newline at end which gives us a blank line before the "Run" line below.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@afishbeck - whoops yes, well spotted, now added (squashed in)

@jakesmith jakesmith force-pushed the HPCC-30419-ecl-usage branch from ab77bbd to 08904cf Compare October 3, 2023 16:26
@jakesmith jakesmith requested a review from afishbeck October 3, 2023 16:27
afishbeck
afishbeck approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@afishbeck afishbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jakesmith looks good.

@ghalliday ghalliday merged commit ac7e11e into hpcc-systems:candidate-9.4.x Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afishbeck afishbeck afishbeck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakesmith @afishbeck @ghalliday