Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-30413 Add option to always capture post-mortem info #17853

Merged
merged 1 commit into from
Oct 4, 2023
Merged

HPCC-30413 Add option to always capture post-mortem info #17853

merged 1 commit into from
Oct 4, 2023

Conversation

jakesmith
Copy link
Member

@jakesmith jakesmith commented Oct 2, 2023 •
edited
Loading

Enabled either globally (i.e. for all components), or for individual components (e.g. Thor).
Usage:

expert:
  alwaysPostMortem: true

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@jakesmith jakesmith requested a review from ghalliday October 2, 2023 13:48
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

https://track.hpccsystems.com/browse/HPCC-30413
Jira updated

ghalliday
ghalliday reviewed Oct 2, 2023
View reviewed changes
Copy link
Member

@ghalliday ghalliday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality looks good. A couple of helm comments.

helm/hpcc/templates/_helpers.tpl Outdated
@@ -689,13 +689,13 @@ Check that the storage and spill planes for a component exist
Add command for a component
*/}}
{{- define "hpcc.componentCommand" -}}
{{- if .me.valgrind -}}
{{- if .me.valgrind -}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't normally indent the root statements inside a define. Was this deliberate?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're right we don't (it looks clearer, but..), I'll revert.

helm/hpcc/templates/_helpers.tpl Outdated
@@ -713,6 +713,9 @@ Add extra args for a component
{{- $debugPlane := .me.debugPlane | default (include "hpcc.getFirstPlaneForCategory" (dict "root" .root "category" "debug")) -}}
{{- include "hpcc.checkPlaneExists" (dict "root" .root "planeName" $debugPlane) -}}
{{- $prefix := include "hpcc.getPlanePrefix" (dict "root" .root "planeName" $debugPlane) -}}
{{- if or (and (hasKey .me "expert") .me.expert.alwaysPostMortem) (and (hasKey .root.Values.global "expert") .root.Values.global.expert.alwaysPostMortem) -}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't short circuited on old versions of helm.
MeExpert := .me.expert | dict
?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, yes good point, will change.

@jakesmith jakesmith requested a review from ghalliday October 3, 2023 10:28
@jakesmith
Copy link
Member Author

@ghalliday - see 2nd commit.

ghalliday
ghalliday requested changes Oct 4, 2023
View reviewed changes
Copy link
Member

@ghalliday ghalliday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jakesmith the csv change should be a different PR - especially switching output over to using it.

system/jlib/jlog.cpp Outdated
@@ -879,7 +956,7 @@ void CategoryLogMsgFilter::reset()
void HandleLogMsgHandlerTable::handleMessage(const LogMsg & msg)
{
CriticalBlock block(crit);
msg.toStringTable(curMsgText.clear(), messageFields);
msg.toStringCSV(curMsgText.clear(), messageFields);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to include this change? I can see it would be useful for simplifying post-processing, but it would need to be on an option.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops, I did not.

@jakesmith jakesmith requested a review from ghalliday October 4, 2023 09:05
@jakesmith
Copy link
Member Author

jakesmith commented Oct 4, 2023 •
edited
Loading

@jakesmith the csv change should be a different PR - especially switching output over to using it.

@ghalliday rolled back unintentional jlog changes - see 3rd commit.

ghalliday
ghalliday approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@ghalliday ghalliday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jakesmith please squash

@jakesmith
HPCC-30413 Add option to always capture post-mortem info
df794a0 
Enabled either globally (i.e. for all components), or for
individual components (e.g. Thor).
Usage:

expert:
  alwaysPostMortem: true

Signed-off-by: Jake Smith <[email protected]>
@jakesmith jakesmith force-pushed the HPCC-30413-post-mortem-always-capture branch from a8290db to df794a0 Compare October 4, 2023 09:40
@jakesmith
Copy link
Member Author

@ghalliday - squashed

@ghalliday ghalliday merged commit 6f4d15e into hpcc-systems:candidate-9.2.x Oct 4, 2023
48 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghalliday ghalliday ghalliday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakesmith @ghalliday