Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-30393 Add new event class and monitor audience #17839

Merged
merged 2 commits into from
Oct 6, 2023

Conversation

ghalliday
Copy link
Member

@ghalliday ghalliday commented Sep 28, 2023

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@ghalliday ghalliday requested a review from rpastrana September 28, 2023 13:45
@ghalliday
Copy link
Member Author

@rpastrana the aim is to add these to 8.12.x for backward compatibility (in case there are any issues), but only generate them in 9.4.x and later.

@github-actions
Copy link

Copy link
Member

@rpastrana rpastrana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ghalliday looks reasonable.
These changes do affect related docs:
https://github.com/hpcc-systems/HPCC-Platform/blob/7b8fa077e457b5890740cc905fa9811a8079b054/helm/examples/logging/README.md#target-audience-filtering
https://github.com/hpcc-systems/HPCC-Platform/blob/7b8fa077e457b5890740cc905fa9811a8079b054/helm/examples/logging/README.md#target-category-filtering
and logAccess ESP interface:
ESPenum LogEventClass : string

ESPenum LogEventClass : string

This change is important, but for future, I want to shift focus to providing OTel exporter based trace streams for standard back-end trace monitoring/processing

Signed-off-by: Gavin Halliday <[email protected]>
@ghalliday ghalliday requested a review from rpastrana September 28, 2023 15:45
Copy link
Member

@rpastrana rpastrana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ghalliday looks good.
There is an ecm enum 'LogEventClass' which first appears in 9.2.x which will need to be updated w/ the new event class "EVT - Event". Since this PR targets an earlier base branch we might need to handle it through another jira.

@rpastrana
Copy link
Member

@g-pan I believe the changes to the README file in this PR need to be reflected in our of your docs. @JamesDeFabia

@ghalliday ghalliday merged commit aa0dacf into hpcc-systems:candidate-8.12.x Oct 6, 2023
46 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants