-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HPCC-30393 Add new event class and monitor audience #17839
Conversation
Signed-off-by: Gavin Halliday <[email protected]>
@rpastrana the aim is to add these to 8.12.x for backward compatibility (in case there are any issues), but only generate them in 9.4.x and later. |
https://track.hpccsystems.com/browse/HPCC-30393 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ghalliday looks reasonable.
These changes do affect related docs:
https://github.com/hpcc-systems/HPCC-Platform/blob/7b8fa077e457b5890740cc905fa9811a8079b054/helm/examples/logging/README.md#target-audience-filtering
https://github.com/hpcc-systems/HPCC-Platform/blob/7b8fa077e457b5890740cc905fa9811a8079b054/helm/examples/logging/README.md#target-category-filtering
and logAccess ESP interface:
ESPenum LogEventClass : string
HPCC-Platform/esp/scm/ws_logaccess.ecm
Line 103 in 7b8fa07
ESPenum LogEventClass : string |
- valid values at time of writing are:
HPCC-Platform/esp/scm/ws_logaccess.ecm
Line 129 in 7b8fa07
* valid values at time of writing are: - valid values at time of writing are:
HPCC-Platform/esp/scm/ws_logaccess.ecm
Line 137 in 7b8fa07
*If searching by "ByTargetAudience", the SearchByValue should contain the 3 letter code associated with the target audience of interest.
This change is important, but for future, I want to shift focus to providing OTel exporter based trace streams for standard back-end trace monitoring/processing
Signed-off-by: Gavin Halliday <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ghalliday looks good.
There is an ecm enum 'LogEventClass' which first appears in 9.2.x which will need to be updated w/ the new event class "EVT - Event". Since this PR targets an earlier base branch we might need to handle it through another jira.
@g-pan I believe the changes to the README file in this PR need to be reflected in our of your docs. @JamesDeFabia |
aa0dacf
into
hpcc-systems:candidate-8.12.x
Type of change:
Checklist:
Smoketest:
Testing: