Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-29934 ECL Watch v9 file explorer component #17733

Open
wants to merge 1 commit into
base: candidate-9.2.x
Choose a base branch
from

Conversation

jeclrsg
Copy link
Contributor

@jeclrsg jeclrsg commented Aug 31, 2023

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@jeclrsg jeclrsg requested a review from GordonSmith August 31, 2023 20:48
@jeclrsg jeclrsg marked this pull request as draft August 31, 2023 20:51
@jeclrsg jeclrsg force-pushed the hpcc-29934-tree-component branch 2 times, most recently from 54bea89 to 4ab9b25 Compare September 6, 2023 13:26
@jeclrsg jeclrsg force-pushed the hpcc-29934-tree-component branch 2 times, most recently from ef87fcd to b4c0a17 Compare September 18, 2023 19:13
@jeclrsg jeclrsg force-pushed the hpcc-29934-tree-component branch from b4c0a17 to 2b786d5 Compare September 18, 2023 20:56
@jeclrsg jeclrsg changed the title wip HPCC-29934 ECL Watch v9 file explorer component Sep 18, 2023
@jeclrsg jeclrsg marked this pull request as ready for review September 18, 2023 20:57
@GordonSmith GordonSmith marked this pull request as draft December 7, 2023 15:56
@jeclrsg jeclrsg force-pushed the hpcc-29934-tree-component branch 4 times, most recently from 12e4f65 to 279af71 Compare January 17, 2024 21:24
@jeclrsg jeclrsg force-pushed the hpcc-29934-tree-component branch 4 times, most recently from 400b3f5 to 746ae9b Compare January 24, 2024 16:50
@jeclrsg jeclrsg marked this pull request as ready for review January 24, 2024 17:14
esp/src/src-react/components/controls/TreeView.tsx Outdated Show resolved Hide resolved
} else {
const layout = JSON.parse(value);
dockpanel.layout(layout);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logic should be commoned up with Metrics and ECLArchive (inside a hook?) - can you open a ticket for this and add the remark:

Don't check value, do the JSON.parse in a try block and test the result for validity.
Add a version to the serialized string and reset when they don't match.

esp/src/src-react/components/LandingZone.tsx Show resolved Hide resolved
esp/src/src-react/components/LandingZone.tsx Outdated Show resolved Hide resolved
esp/src/src-react/components/LandingZone.tsx Show resolved Hide resolved
esp/src/src-react/components/LandingZone.tsx Show resolved Hide resolved
@jeclrsg jeclrsg force-pushed the hpcc-29934-tree-component branch from 746ae9b to 88f2e4d Compare January 26, 2024 19:04
@jeclrsg jeclrsg force-pushed the hpcc-29934-tree-component branch from 88f2e4d to a6e4cb0 Compare March 6, 2024 22:24
@jeclrsg jeclrsg marked this pull request as draft March 7, 2024 14:52
@jeclrsg jeclrsg force-pushed the hpcc-29934-tree-component branch 2 times, most recently from 344bf06 to f80affb Compare April 8, 2024 20:27
@jeclrsg jeclrsg marked this pull request as ready for review April 8, 2024 21:04
@jeclrsg jeclrsg force-pushed the hpcc-29934-tree-component branch from f80affb to 298e3c8 Compare July 10, 2024 19:31
@jeclrsg jeclrsg requested a review from GordonSmith July 16, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants