-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HPCC-29934 ECL Watch v9 file explorer component #17733
Open
jeclrsg
wants to merge
1
commit into
hpcc-systems:candidate-9.2.x
Choose a base branch
from
jeclrsg:hpcc-29934-tree-component
base: candidate-9.2.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
HPCC-29934 ECL Watch v9 file explorer component #17733
jeclrsg
wants to merge
1
commit into
hpcc-systems:candidate-9.2.x
from
jeclrsg:hpcc-29934-tree-component
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeclrsg
commented
Aug 31, 2023
jeclrsg
force-pushed
the
hpcc-29934-tree-component
branch
2 times, most recently
from
September 6, 2023 13:26
54bea89
to
4ab9b25
Compare
jeclrsg
force-pushed
the
hpcc-29934-tree-component
branch
2 times, most recently
from
September 18, 2023 19:13
ef87fcd
to
b4c0a17
Compare
jeclrsg
force-pushed
the
hpcc-29934-tree-component
branch
from
September 18, 2023 20:56
b4c0a17
to
2b786d5
Compare
jeclrsg
force-pushed
the
hpcc-29934-tree-component
branch
4 times, most recently
from
January 17, 2024 21:24
12e4f65
to
279af71
Compare
jeclrsg
force-pushed
the
hpcc-29934-tree-component
branch
4 times, most recently
from
January 24, 2024 16:50
400b3f5
to
746ae9b
Compare
GordonSmith
requested changes
Jan 26, 2024
} else { | ||
const layout = JSON.parse(value); | ||
dockpanel.layout(layout); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This logic should be commoned up with Metrics and ECLArchive (inside a hook?) - can you open a ticket for this and add the remark:
Don't check value, do the JSON.parse in a try block and test the result for validity.
Add a version to the serialized string and reset when they don't match.
jeclrsg
force-pushed
the
hpcc-29934-tree-component
branch
from
January 26, 2024 19:04
746ae9b
to
88f2e4d
Compare
jeclrsg
force-pushed
the
hpcc-29934-tree-component
branch
from
March 6, 2024 22:24
88f2e4d
to
a6e4cb0
Compare
jeclrsg
force-pushed
the
hpcc-29934-tree-component
branch
2 times, most recently
from
April 8, 2024 20:27
344bf06
to
f80affb
Compare
Signed-off-by: Jeremy Clements <[email protected]>
jeclrsg
force-pushed
the
hpcc-29934-tree-component
branch
from
July 10, 2024 19:31
f80affb
to
298e3c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change:
Checklist:
Smoketest:
Testing: