HPCC-31382 Activity CostFileAccess not always updated to sg scope

Subgraph's CostFileAccess was being set before the activities stats are updated, meaning that some activities CostFileAccess is not updated to subgraph scope. Signed-off-by: Shamser Ahmed <[email protected]>
hpcc-systems · Mar 1, 2024 · ffb592e · ffb592e
1 parent 5f9b805
commit ffb592e
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/thorlcr/graph/thgraphmaster.cpp b/thorlcr/graph/thgraphmaster.cpp
@@ -2925,10 +2925,6 @@ bool CMasterGraph::deserializeStats(unsigned node, MemoryBuffer &mb)
 void CMasterGraph::getStats(IStatisticGatherer &stats)
 {
     stats.addStatistic(StNumSlaves, queryClusterWidth());
-    cost_type costDiskAccess = getDiskAccessCost();
-    if (costDiskAccess)
-        stats.addStatistic(StCostFileAccess, costDiskAccess);
-
     // graph specific stats
     graphStats.getStats(stats);
 
@@ -2957,6 +2953,9 @@ void CMasterGraph::getStats(IStatisticGatherer &stats)
             activity->getActivityStats(stats);
         }
     }
+    cost_type costDiskAccess = getDiskAccessCost();
+    if (costDiskAccess)
+        stats.addStatistic(StCostFileAccess, costDiskAccess);
 }
 
 cost_type CMasterGraph::getDiskAccessCost()