HPCC-31003 Move instead of copying object to improve performance

Signed-off-by: Shamser Ahmed <[email protected]>
hpcc-systems · Dec 20, 2024 · fca7756 · fca7756
1 parent 70ccefc
commit fca7756
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/common/workunit/workunit.cpp b/common/workunit/workunit.cpp
@@ -2708,7 +2708,7 @@ void StatisticsAggregator::recordStats(IStatisticCollection * sourceStats, unsig
     verifyex(graphScopeId.setScopeText(graphName));
     StatsScopeId wfScopeId(SSTworkflow, wfid);
     StatsScopeId sgScopeId(SSTsubgraph, sgId);
-    statsCollection->recordStats(mapping, sourceStats, {wfScopeId, graphScopeId, sgScopeId});
+    statsCollection->recordStats(mapping, sourceStats, {std::move(wfScopeId), std::move(graphScopeId), std::move(sgScopeId)});
 }
 
 // Recalculate aggregates and then write the aggregates to global stats (dali)

diff --git a/system/jlib/jstats.h b/system/jlib/jstats.h
@@ -43,8 +43,8 @@ inline constexpr stat_type statPercent(stat_type  value) { return (stat_type)(va
 inline constexpr stat_type statPercentageOf(stat_type value, stat_type per) { return value * per / 10000; }
 
 inline StatisticKind queryStatsVariant(StatisticKind kind) { return (StatisticKind)(kind & ~StKindMask); }
-inline cost_type money2cost_type(double money) { return money * 1E6; }
-inline double cost_type2money(cost_type cost) { return ((double) cost) / 1E6; }
+constexpr cost_type money2cost_type(const double money) { return money * 1E6; }
+constexpr double cost_type2money(cost_type cost) { return ((double) cost) / 1E6; }
 
 extern jlib_decl void formatTime(StringBuffer & out, unsigned __int64 value);
 //---------------------------------------------------------------------------------------------------------------------