HPCC-31379 Fix new OSX 13 compiler warnings

Signed-off-by: Gordon Smith <[email protected]>
hpcc-systems · Mar 1, 2024 · fb476a4 · fb476a4
1 parent 193e658
commit fb476a4
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 8 deletions.
diff --git a/ecl/hql/CMakeLists.txt b/ecl/hql/CMakeLists.txt
@@ -167,6 +167,9 @@ if (CMAKE_COMPILER_IS_GNUCC OR CMAKE_COMPILER_IS_CLANG)
 
   #Compiler complains about an unused function yyunput, and make sure that any warnings are not reported as errors
   set_source_files_properties (hqllex.cpp PROPERTIES COMPILE_FLAGS " -Wno-unused-function -Wno-error")
+
+  #Compiler complains about a variable is set but not used 
+  set_source_files_properties (hqlgram.cpp PROPERTIES COMPILE_FLAGS " -Wunused-but-set-variable -Wno-error")
 endif()
 
 if (WIN32)

diff --git a/ecl/hql/hqlexpr.cpp b/ecl/hql/hqlexpr.cpp
@@ -1146,8 +1146,8 @@ void HqlParseContext::finishMeta(bool isSeparateFile, bool success, bool generat
     {
 #if 0
         IPropertyTree* tos = curMeta().meta;
-# This is disabled as the location of the cache file needs to be
-# in the original location for now.  This may re-visited in the future.
+// This is disabled as the location of the cache file needs to be
+// in the original location for now.  This may re-visited in the future.
         if (isSeparateFile && hasCacheLocation())
         {
             StringBuffer fullName;

diff --git a/ecl/hqlcpp/hqlresource.cpp b/ecl/hqlcpp/hqlresource.cpp
@@ -5549,15 +5549,19 @@ void EclResourcer::removeDuplicateIndependentLinks(CSplitterInfo & connections,
                 ResourcerInfo & sinkInfo = *queryResourceInfo(sink);
                 if (allInputsPulledIndependently(sink))
                 {
+#ifdef TRACE_BALANCED
                     unsigned numRemoved = 0;
+#endif
                     for (unsigned j=info.balancedLinks.ordinality()-1; j > i; j--)
                     {
                         CSplitterLink & next = info.balancedLinks.item(j);
                         if (next.hasSource(expr) && next.hasSink(sink))
                         {
                             info.balancedLinks.remove(j);
                             sinkInfo.balancedLinks.zap(next);
+#ifdef TRACE_BALANCED
                             numRemoved++;
+#endif
                         }
                     }
 

diff --git a/roxie/ccd/ccdqueue.cpp b/roxie/ccd/ccdqueue.cpp
@@ -1262,7 +1262,6 @@ class RoxieQueue : public CInterface, implements IThreadFactory
 
     bool remove(RoxiePacketHeader &x)
     {
-        unsigned scanLength = 0;
         ISerializedRoxieQueryPacket *found = nullptr;
         {
             CriticalBlock qc(qcrit);
@@ -1273,7 +1272,6 @@ class RoxieQueue : public CInterface, implements IThreadFactory
                 ISerializedRoxieQueryPacket *queued = waiting.item(i);
                 if (queued)
                 {
-                    scanLength++;
                     if (queued->queryHeader().matchPacket(x))
                     {
                         waiting.set(i, NULL);

diff --git a/system/jlib/jdebug.cpp b/system/jlib/jdebug.cpp
@@ -3286,7 +3286,6 @@ void printProcMap(const char *fn, bool printbody, bool printsummary, StringBuffe
     }
     while (reader.nextln()) {
         const char *ln = reader.ln;
-        unsigned n=0;
         if (*ln) {
             offset_t start = readHexNum(ln);
             if (last&&(last!=start)) {
@@ -3360,7 +3359,6 @@ void printProcMap(const char *fn, bool printbody, bool printsummary, StringBuffe
                 recs[t].total += ssz;
                 if (ssz>recs[t].largest)
                     recs[t].largest = ssz;
-                n++;
                 last = end;
 #ifndef __64BIT__
                 if ((end<0xffffffff)&&(end>=0xc0000000))    // rest is OS (32-bit only)

diff --git a/tools/hidl/hidlcomp.cpp b/tools/hidl/hidlcomp.cpp
@@ -2254,10 +2254,8 @@ void ModuleInfo::write_body_class()
     }
     outf("}, %d };\n\n",version);
 
-    int fn=0;
     for (ProcInfo *pi=procs; pi; pi=pi->next)
     {
-        fn++;
         pi->write_body_method_structs2(name);
     }
     outs("\n");