guard against @connected falling below zero

Signed-off-by: Jake Smith <[email protected]>
hpcc-systems · Jun 20, 2024 · c964156 · c964156
1 parent 59ff9d2
commit c964156
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/common/workunit/wujobq.cpp b/common/workunit/wujobq.cpp
@@ -1128,9 +1128,11 @@ class CJobQueue: public CJobQueueBase, implements IJobQueue
             ForEachQueue(qd)
             {
                 IPropertyTree *croot = queryClientRootSession(*qd);
-                unsigned newConnectedCount = croot->getPropInt64("@connected",0)-1;
-                if (newConnectedCount)
-                    croot->setPropInt64("@connected", newConnectedCount);
+                unsigned connectedCount = croot->getPropInt64("@connected");
+                if (connectedCount) // should never be 0, but guard JIC
+                    connectedCount--;
+                if (connectedCount)
+                    croot->setPropInt64("@connected", connectedCount);
                 else
                     qd->root->removeTree(croot);
             }