Merge pull request #18071 from ghalliday/issue30299

HPCC-30299 Update secrets in the background to avoid roxie stalls Reviewed-By: Anthony Fishbeck <[email protected]> Reviewed-by: Mark Kelly [email protected] Reviewed-By: Richard Chapman <[email protected]> Merged-by: Gavin Halliday <[email protected]>
hpcc-systems · Jan 3, 2024 · ababf40 · ababf40
2 parents c9afd94 + 3a50fc1
commit ababf40
Show file tree

Hide file tree

Showing 5 changed files with 403 additions and 71 deletions.
diff --git a/helm/hpcc/values.schema.json b/helm/hpcc/values.schema.json
@@ -2322,6 +2322,10 @@
           "default": false,
           "description": "Require SOAPCALL and HTTPCALL URLs are secrets or mapped to secrets"
         },
+        "updateSecretsInBackground": {
+          "type": "boolean",
+          "description": "Preemptively update secrets that are active and about to expire in the background"
+        },
         "expert": {
           "description": "Custom internal options usually reserved for internal testing",
           "type": "object"

diff --git a/roxie/ccd/ccdmain.cpp b/roxie/ccd/ccdmain.cpp
@@ -945,6 +945,8 @@ int CCD_API roxie_main(int argc, const char *argv[], const char * defaultYaml)
 #endif
 
         roxieMetrics.setown(createRoxieMetricsManager());
+        if (topology->getPropBool("@updateSecretsInBackground", !runOnce))
+            startSecretUpdateThread(0);
 
         Owned<IPropertyTreeIterator> userMetrics = topology->getElements("./UserMetric");
         ForEach(*userMetrics)
@@ -1686,6 +1688,7 @@ int CCD_API roxie_main(int argc, const char *argv[], const char * defaultYaml)
         E->Release();
     }
 
+    stopSecretUpdateThread();
     roxieMetrics.clear();
 #ifndef _CONTAINERIZED
     stopPerformanceMonitor();