Changes following review

Signed-off-by: Richard Chapman <[email protected]>
hpcc-systems · Jul 24, 2024 · a7fd5dd · a7fd5dd
1 parent b0fe74a
commit a7fd5dd
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 11 deletions.
diff --git a/roxie/udplib/udptrr.cpp b/roxie/udplib/udptrr.cpp
@@ -1424,14 +1424,10 @@ class CReceiveManager : implements IReceiveManager, public CInterface
                                 DBGLOG("UdpReceiver: %u bytes received packet %" SEQF "u %x from %s", res, hdr.sendSeq, hdr.pktSeq, hdr.node.getTraceText(s).str());
                             }
                         }
-                        {
-                            UdpRdTracker::TimeDivision d(timeTracker, UdpRdTracker::pushing);
-                            parent.input_queue->pushOwn(b);
-                        }
-                        {
-                            UdpRdTracker::TimeDivision d(timeTracker, UdpRdTracker::allocating);
-                            b = udpBufferManager->allocate();
-                        }
+                        d.switchState(UdpRdTracker::pushing);
+                        parent.input_queue->pushOwn(b);
+                        d.switchState(UdpRdTracker::allocating);
+                        b = udpBufferManager->allocate();
                     }
                     if (udpStatsReportInterval)
                     {

diff --git a/system/jlib/jmisc.hpp b/system/jlib/jmisc.hpp
@@ -354,8 +354,11 @@ template<unsigned NUMSTATES, bool reportOther> class TimeDivisionTracker
         unsigned prevState = currentState;
         unsigned __int64 now = get_cycles_now();
         if (reportIntervalCycles && now - lastReport >= reportIntervalCycles)
+        {
             report(true);
-        if (newState != currentState)
+            now = get_cycles_now();
+        }
+        if (newState != prevState)
         {
             totals[currentState] += now - lastTick;
             currentState = newState;
@@ -404,12 +407,13 @@ template<unsigned NUMSTATES, bool reportOther> class TimeDivisionTracker
                 doneOne = true;
             }
             if (reset)
+            {
                 totals[i] = 0;
+                counts[i] = 0;
+            }
         }
         if (doneOne)
             DBGLOG("%s", str.str());
-        if (reset)
-            lastTick = now;
     }
 
     class TimeDivision