Merge pull request #18769 from ghalliday/issue32068

HPCC-32068 Fix some (false postive) coverity warnings Reviewed-By: Attila Vamos <[email protected]> Merged-by: Gavin Halliday <[email protected]>
hpcc-systems · Jul 17, 2024 · 9b62c6f · 9b62c6f
2 parents 466476f + fd170ff
commit 9b62c6f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/system/jlib/jsmartsock.cpp b/system/jlib/jsmartsock.cpp
@@ -30,6 +30,7 @@ class SmartSocketListParser
 public:
     SmartSocketListParser(const char * text)
     {
+        assertex(text);
         fullText = strdup(text);
     }
 
@@ -235,11 +236,9 @@ CSmartSocketFactory::CSmartSocketFactory(IPropertyTree &service, bool _retry, un
     dnsInterval=_dnsInterval;
 
     retry = _retry;
+    retryInterval = _retryInterval;
     if (retry)
-    {
-        retryInterval = _retryInterval;
         this->start(false);
-    }
 }
 
 CSmartSocketFactory::CSmartSocketFactory(const char *_socklist, IPropertyTree* _tlsConfig, bool _retry, unsigned _retryInterval, unsigned _dnsInterval)
@@ -261,11 +260,9 @@ CSmartSocketFactory::CSmartSocketFactory(const char *_socklist, IPropertyTree* _
     dnsInterval=_dnsInterval;
 
     retry = _retry;
+    retryInterval = _retryInterval;
     if (retry)
-    {
-        retryInterval = _retryInterval;
         this->start(false);
-    }
 }
 
 CSmartSocketFactory::~CSmartSocketFactory()

diff --git a/testing/unittests/jstreamtests.cpp b/testing/unittests/jstreamtests.cpp
@@ -510,7 +510,7 @@ class JlibStreamStressTest : public CppUnit::TestFixture
     public:
         CDataProvider & dataProvider;
         IBufferedSerialOutputStream * out;
-        offset_t totalSent;
+        offset_t totalSent = 0;
         unsigned numRows;
     };