HPCC-30455 Fix a bug when trying to validate empty host

When File Upload dialog box is displayed in a containerized environment, it sends a FileList request with an empty Netaddr to ESP FileSpray service. The service should not validate the Netaddr. Signed-off-by: wangkx <[email protected]>
hpcc-systems · Oct 17, 2023 · 9605b7f · 9605b7f
1 parent 71a73b6
commit 9605b7f
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/esp/smc/SMCLib/TpCommon.cpp b/esp/smc/SMCLib/TpCommon.cpp
@@ -175,9 +175,10 @@ extern TPWRAPPER_API IPropertyTree* getDropZoneAndValidateHostAndPath(const char
         dropZone.setown(getDropZonePlane(dropZoneName));
         if (!dropZone)
             throw makeStringExceptionV(ECLWATCH_INVALID_INPUT, "DropZone '%s' not found.", dropZoneName);
-        if (!validateDropZone(dropZone, pathToCheck, hostToCheck, isIPAddress(hostToCheck)))
-            throw makeStringExceptionV(ECLWATCH_INVALID_INPUT, "The host '%s' or path '%s' is not valid for dropzone %s.",
-                isEmptyString(host) ? "unspecified" : host, isEmptyString(path) ? "unspecified" : path, dropZoneName);
+        if (!isEmptyString(hostToCheck) && !isHostInPlane(dropZone, hostToCheck, isIPAddress(hostToCheck)))
+            throw makeStringExceptionV(ECLWATCH_INVALID_INPUT, "The host '%s' is not valid for dropzone %s.", host, dropZoneName);
+        if (!isEmptyString(pathToCheck) && !isPathInPlane(dropZone, pathToCheck))
+            throw makeStringExceptionV(ECLWATCH_INVALID_INPUT, "The path '%s' is not valid for dropzone %s.", path, dropZoneName);
     }
     return dropZone.getClear();
 }