Merge pull request #17763 from jeclrsg/hpcc-30222-WU-details-calling-…

…GetLogs

HPCC-30222 ECL Watch cut back multiple calls to WsLogaccess.GetLogs

Reviewed-by: Gordon Smith <[email protected]>
Merged-by: Gavin Halliday <[email protected]>

esp/src/src-react/components/WorkunitDetails.tsx

@@ -1,10 +1,12 @@
 import * as React from "react";
 import { IPivotItemProps, Pivot, PivotItem } from "@fluentui/react";
+import { scopedLogger } from "@hpcc-js/util";
 import { SizeMe } from "react-sizeme";
 import nlsHPCC from "src/nlsHPCC";
 import { service, hasLogAccess } from "src/ESPLog";
 import { useWorkunit } from "../hooks/workunit";
 import { useUserTheme } from "../hooks/theme";
+import { useDeepEffect } from "../hooks/deepHooks";
 import { DojoAdapter } from "../layouts/DojoAdapter";
 import { pivotItemStyle } from "../layouts/pivot";
 import { pushUrl } from "../util/history";
@@ -22,6 +24,8 @@ import { WorkunitSummary } from "./WorkunitSummary";
 import { Result } from "./Result";
 import { Logs } from "./Logs";
 
+const logger = scopedLogger("src-react/components/WorkunitDetails.tsx");
+
 interface WorkunitDetailsProps {
     wuid: string;
     tab?: string;
@@ -54,20 +58,21 @@ export const WorkunitDetails: React.FunctionComponent<WorkunitDetailsProps> = ({
 
     const [logCount, setLogCount] = React.useState<number | string>("*");
     const [logsDisabled, setLogsDisabled] = React.useState(true);
-    React.useEffect(() => {
+
+    useDeepEffect(() => {
         hasLogAccess().then(response => {
             setLogsDisabled(!response);
             return response;
         }).then(hasLogAccess => {
             if (hasLogAccess) {
                 service.GetLogsEx({ ...queryParams, jobId: wuid, LogLineStartFrom: 0, LogLineLimit: 10 }).then(response => {    // HPCC-27711 - Requesting LogLineLimit=1 causes issues
                     setLogCount(response.total);
-                });
+                }).catch((err) => logger.error(err));
             }
         }).catch(() => {
             setLogsDisabled(true);
         });
-    }, [queryParams, wuid]);
+    }, [wuid], [queryParams]);
 
     return <SizeMe monitorHeight>{({ size }) =>
         <Pivot overflowBehavior="menu" style={{ height: "100%" }} selectedKey={tab} onLinkClick={evt => pushUrl(`/workunits/${wuid}/${evt.props.itemKey}`)}>