Skip to content

Commit

Permalink
HPCC-30704 Prevent scale down evict
Browse files Browse the repository at this point in the history
It is generally not safe for HPCC pods to be evicted based on
scale down events because most are stateful (particularly those
that have been dynamically launched as jobs).
For now, prevent all pods from being deemed suitable for eviction
by k8s on scale-down.
We may later allow some that have replicas and aren't stateful
or 'cheap' to evict and move and handle graceful termination
to be safe, but it will then be better to use PodDisruptionBudget's

Signed-off-by: Jake Smith <[email protected]>
  • Loading branch information
jakesmith committed Nov 2, 2023
1 parent fb5d871 commit 83b961f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion helm/hpcc/templates/_helpers.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -2533,7 +2533,7 @@ A template to generate component annotations, merges static default annotations
Pass in dict with .root, .me
*/}}
{{- define "hpcc.generateAnnotations" -}}
{{- $annotations := dict -}}
{{- $annotations := dict "cluster-autoscaler.kubernetes.io/safe-to-evict" false -}}
{{- if hasKey .root.Values.global "componentAnnotations" -}}{{- $annotations = merge $annotations .root.Values.global.componentAnnotations -}}{{- end -}}
{{- if hasKey .me "annotations" -}}{{- $annotations = merge $annotations .me.annotations -}}{{- end -}}
{{- range $key, $value := $annotations }}
Expand Down

0 comments on commit 83b961f

Please sign in to comment.