HPCC-30938 checkCount/getCount double counting seeks

checkCount/getCount does not need to count/note seeks, because the _lookup it calls that is passed the same 'stats' container already does so. Signed-off-by: Jake Smith <[email protected]>
hpcc-systems · Nov 29, 2023 · 135f5f0 · 135f5f0
1 parent 92bba5b
commit 135f5f0
Showing 1 changed file with 0 additions and 6 deletions.
diff --git a/system/jhtree/jhtree.cpp b/system/jhtree/jhtree.cpp
@@ -2027,7 +2027,6 @@ unsigned __int64 CKeyCursor::getCount(KeyStatsCollector &stats)
 {
     reset();
     unsigned __int64 result = 0;
-    unsigned lseeks = 0;
     unsigned lastRealSeg = filter->lastRealSeg();
     bool unfiltered = filter->isUnfiltered();
     for (;;)
@@ -2037,23 +2036,20 @@ unsigned __int64 CKeyCursor::getCount(KeyStatsCollector &stats)
             unsigned __int64 locount = getSequence();
             endRange(lastRealSeg);
             _ltEqual(stats);
-            lseeks++;
             result += getSequence()-locount+1;
             if (!incrementKey(lastRealSeg))
                 break;
         }
         else
             break;
     }
-    stats.noteSeeks(lseeks, 0, 0);
     return result;
 }
 
 unsigned __int64 CKeyCursor::checkCount(unsigned __int64 max, KeyStatsCollector &stats)
 {
     reset();
     unsigned __int64 result = 0;
-    unsigned lseeks = 0;
     unsigned lastFullSeg = filter->lastFullSeg();
     bool unfiltered = filter->isUnfiltered();
     if (lastFullSeg == (unsigned) -1)
@@ -2071,7 +2067,6 @@ unsigned __int64 CKeyCursor::checkCount(unsigned __int64 max, KeyStatsCollector
             unsigned __int64 locount = getSequence();
             endRange(lastFullSeg);
             _ltEqual(stats);
-            lseeks++;
             result += getSequence()-locount+1;
             if (max && (result > max))
                 break;
@@ -2081,7 +2076,6 @@ unsigned __int64 CKeyCursor::checkCount(unsigned __int64 max, KeyStatsCollector
         else
             break;
     }
-    stats.noteSeeks(lseeks, 0, 0);
     return result;
 }