Skip to content

Commit

Permalink
Merge remote-tracking branch 'origin/candidate-9.2.x' into candidate-…
Browse files Browse the repository at this point in the history
…9.4.x

Signed-off-by: Gavin Halliday <[email protected]>
  • Loading branch information
ghalliday committed Sep 26, 2023
2 parents a4c71a7 + 442ebef commit 0448af1
Show file tree
Hide file tree
Showing 4 changed files with 20 additions and 6 deletions.
18 changes: 16 additions & 2 deletions dali/base/dadfs.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1378,9 +1378,23 @@ static void checkLogicalScope(const char *scopename,IUserDescriptor *user,bool r
SecAccessFlags perm = getScopePermissions(scopename,user,auditflags);
IDFS_Exception *e = NULL;
if (readreq&&!HASREADPERMISSION(perm))
e = new CDFS_Exception(DFSERR_LookupAccessDenied,scopename);
{
StringBuffer scopeDescription;
StringBuffer username("");
if (user)
user->getUserName(username);
scopeDescription.appendf("%s user '%s', assigned access %s (%d)", scopename, username.str(), getSecAccessFlagName(perm), perm);
e = new CDFS_Exception(DFSERR_LookupAccessDenied,scopeDescription);
}
else if (createreq&&!HASWRITEPERMISSION(perm))
e = new CDFS_Exception(DFSERR_CreateAccessDenied,scopename);
{
StringBuffer scopeDescription;
StringBuffer username("");
if (user)
user->getUserName(username);
scopeDescription.appendf("%s user '%s', assigned access %s (%d)", scopename, username.str(), getSecAccessFlagName(perm), perm);
e = new CDFS_Exception(DFSERR_CreateAccessDenied,scopeDescription);
}
if (e)
throw e;
}
Expand Down
4 changes: 2 additions & 2 deletions esp/src/src-react/components/Files.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -175,8 +175,8 @@ export const Files: React.FunctionComponent<FilesProps> = ({
},
},
Owner: { label: nlsHPCC.Owner },
SuperOwners: { label: nlsHPCC.SuperOwner },
Description: { label: nlsHPCC.Description },
SuperOwners: { label: nlsHPCC.SuperOwner, sortable: false },
Description: { label: nlsHPCC.Description, sortable: false },
NodeGroup: { label: nlsHPCC.Cluster },
Records: {
label: nlsHPCC.Records,
Expand Down
2 changes: 1 addition & 1 deletion esp/src/src-react/components/Workunits.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ export const Workunits: React.FunctionComponent<WorkunitsProps> = ({
Owner: { label: nlsHPCC.Owner, width: 80 },
Jobname: { label: nlsHPCC.JobName },
Cluster: { label: nlsHPCC.Cluster },
RoxieCluster: { label: nlsHPCC.RoxieCluster },
RoxieCluster: { label: nlsHPCC.RoxieCluster, sortable: false },
State: { label: nlsHPCC.State, width: 60 },
TotalClusterTime: {
label: nlsHPCC.TotalClusterTime, width: 120,
Expand Down
2 changes: 1 addition & 1 deletion esp/src/src-react/components/forms/AddToSuperfile.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ export const AddToSuperfile: React.FunctionComponent<AddToSuperfileProps> = ({
<table className={`${componentStyles.twoColumnTable} ${componentStyles.selectionTable}`}>
<thead>
<tr>
<th>{nlsHPCC.TargetName}</th>
<th>{nlsHPCC.LogicalName}</th>
</tr>
</thead>
<tbody>
Expand Down

0 comments on commit 0448af1

Please sign in to comment.