Skip to content

Commit

Permalink
Merge pull request #17889 from wangkx/h30477
Browse files Browse the repository at this point in the history
HPCC-30477 Fix a bug in checkPlaneFilePermissions()

Reviewed-by: Jake Smith <[email protected]>
Reviewed-by: Gavin Halliday <[email protected]>
Merged-by: Gavin Halliday <[email protected]>
  • Loading branch information
ghalliday authored Oct 12, 2023
2 parents 3614a42 + 20f8b31 commit 00fb525
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion dali/dfu/dfurun.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -667,7 +667,7 @@ class CDFUengine: public CInterface, implements IDFUengine
if (write)
auditflags |= DALI_LDAP_WRITE_WANTED;

SecAccessFlags perm;
SecAccessFlags perm = SecAccess_None;
IClusterInfo *iClusterInfo = fd->queryClusterNum(0);
const char *planeName = iClusterInfo->queryGroupName();
if (!isEmptyString(planeName))
Expand Down Expand Up @@ -697,6 +697,7 @@ class CDFUengine: public CInterface, implements IDFUengine
Owned<IConstEnvironment> env = factory->openEnvironment();
if (env->isDropZoneRestrictionEnabled())
throw makeStringException(-1,"Empty plane name.");
perm = SecAccess_Full; //Not able to check DropZone permissions without a plane name
#else
throw makeStringException(-1,"Unexpected empty plane name."); // should never be the case in containerized setups
#endif
Expand Down

0 comments on commit 00fb525

Please sign in to comment.