Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fp8] unsqueeze scale to make all_reduce_fp8 compatible with torch.compile #6026

Conversation

GuangyaoZhang
Copy link
Contributor

@GuangyaoZhang GuangyaoZhang commented Aug 22, 2024

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs
  • I have installed pre-commit: pip install pre-commit && pre-commit install

🚨 Issue number

resolved #6025

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@GuangyaoZhang GuangyaoZhang changed the title unsqueeze scale to make all_reduce_fp8 compatible with torch.compile [fp8] unsqueeze scale to make all_reduce_fp8 compatible with torch.compile Aug 22, 2024
@GuangyaoZhang GuangyaoZhang marked this pull request as ready for review August 22, 2024 06:29
@GuangyaoZhang GuangyaoZhang requested a review from a team as a code owner August 22, 2024 06:29
@GuangyaoZhang
Copy link
Contributor Author

Not neccessary

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Not necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants