Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLHF] Fix bugs, tested #4860

Closed
wants to merge 55 commits into from
Closed

[RLHF] Fix bugs, tested #4860

wants to merge 55 commits into from

Conversation

YeAnbang
Copy link
Contributor

@YeAnbang YeAnbang commented Oct 6, 2023

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@TongLi3701
Copy link
Member

Hi @YeAnbang ,

is this branch ready to review? Could you check the CI and make sure they are all passed.

LICENSE Outdated Show resolved Hide resolved
@TongLi3701 TongLi3701 changed the title Rlhf fix bugs. Tested. [RLHF] Fix bugs, tested Nov 8, 2023
@YeAnbang YeAnbang requested a review from a team as a code owner November 9, 2023 06:44
@YeAnbang YeAnbang requested a review from ver217 November 10, 2023 01:44
LORA_MANAGER.merge_weights = True
model.eval()
# save model checkpoint after fitting on only rank0
strategy.save_pretrained(model, path=args.save_path, only_rank0=True, tokenizer=tokenizer)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only_rank0 is removed in be400a0. You can probably omit this field.

@TongLi3701 TongLi3701 closed this Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants