Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chat] support session-based training #4313

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

chengeharrison
Copy link
Contributor

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

Support session-based training.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

Copy link
Member

@TongLi3701 TongLi3701 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Yuanchen,

Overall looks good, some comments.

Copy link
Member

@TongLi3701 TongLi3701 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Yuanchen.

Only one minor comment.

applications/Chat/coati/dataset/sft_dataset.py Outdated Show resolved Hide resolved
Copy link
Member

@TongLi3701 TongLi3701 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Yuanchen

@TongLi3701 TongLi3701 merged commit 5187c96 into hpcaitech:main Jul 28, 2023
2 checks passed
jamesthesnake added a commit to jamesthesnake/ColossalAI that referenced this pull request Jul 29, 2023
support session-based training (hpcaitech#4313)
flybird11111 pushed a commit to flybird11111/ColossalAI that referenced this pull request Aug 1, 2023
Co-authored-by: Yuanchen Xu <[email protected]>

[coloattention] coloattention support flash attention 2

[coloattention] coloattention support flash attention 2

[coloattention] coloattention support flash attention 2

[coloattention] coloattention support flash attention 2

[coloattention] coloattention support flash attention 2

[coloattention] coloattention support flash attention 2

[coloattention] coloattention support flash attention 2
flybird11111 pushed a commit to flybird11111/ColossalAI that referenced this pull request Aug 1, 2023
Co-authored-by: Yuanchen Xu <[email protected]>

[coloattention] coloattention support flash attention 2

[coloattention] coloattention support flash attention 2

[coloattention] coloattention support flash attention 2

[coloattention] coloattention support flash attention 2

[coloattention] coloattention support flash attention 2
flybird11111 pushed a commit to flybird11111/ColossalAI that referenced this pull request Aug 1, 2023
Co-authored-by: Yuanchen Xu <[email protected]>

[coloattention] coloattention support flash attention 2

[coloattention] coloattention support flash attention 2

[coloattention] coloattention support flash attention 2

[coloattention] coloattention support flash attention 2

[coloattention] coloattention support flash attention 2

[coloattention] coloattention support flash attention 2

[coloattention] coloattention support flash attention 2

[coloattention] coloattention support flash attention 2

support session-based training (hpcaitech#4313)

Co-authored-by: Yuanchen Xu <[email protected]>

[coloattention] coloattention support flash attention 2

[coloattention] coloattention support flash attention 2

[coloattention] coloattention support flash attention 2

[coloattention] coloattention support flash attention 2

[coloattention] coloattention support flash attention 2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants