-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to proc/file ops to handle kernel 5.6 series #33
Open
tonycurtis
wants to merge
9
commits into
hpc:master
Choose a base branch
from
tonycurtis:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
ec47806
Changes to proc/file ops to handle kernel 5.6 series
tonycurtis 416136d
Fix typos in procfs_ops
tonycurtis 03dd9c7
Changes to proc/file ops to handle kernel 5.6 series
tonycurtis fb67a63
Merge branch 'master' of github.com:tonycurtis/xpmem
tonycurtis 22eac4e
Fix pre 5.6 linux kernels
tonycurtis eed9f0b
Messed up struct for pre 5.6 kernels
tonycurtis 5e4b9c0
Add support for Linux kernel 5.8 series. Lock field name change sem …
tonycurtis 83144e3
Add new kernel version to dkms build
tonycurtis 07a2806
Remove stray '$'
tonycurtis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -621,11 +621,21 @@ xpmem_unpin_procfs_open(struct inode *inode, struct file *file) | |
return single_open(file, xpmem_unpin_procfs_show, PDE_DATA(inode)); | ||
} | ||
|
||
#if LINUX_VERSION_CODE >= KERNEL_VERSION(5, 6, 0) | ||
struct proc_ops xpmem_unpin_procfs_ops = { | ||
.proc_lseek = seq_lseek, | ||
.proc_read = seq_read, | ||
.proc_write = xpmem_unpin_procfs_write, | ||
.proc_open = xpmem_unpin_procfs_open, | ||
.proc_release = single_release, | ||
}; | ||
#else | ||
struct file_operations xpmem_unpin_procfs_ops = { | ||
.owner = THIS_MODULE, | ||
.llseek = seq_lseek, | ||
.read = seq_read, | ||
.write = xpmem_unpin_procfs_write, | ||
.read = seq_read, | ||
.write = xpmem_unpin_procfs_write, | ||
.open = xpmem_unpin_procfs_open, | ||
.release = single_release, | ||
}; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks like a merge issue. I don't think this will compile with 5.5.x and older. |
||
#endif /* kernel 5.6 */ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
owner set twice?