Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for issue with source_download set to latest #752

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from
Open

fix for issue with source_download set to latest #752

wants to merge 15 commits into from

Conversation

debonisd
Copy link
Collaborator

@debonisd debonisd commented Mar 1, 2024

Code review checklist:

  • Code is generally sensical and well commented
  • Variable/function names all telegraph their purpose and contents
  • Functions/classes have useful doc strings
  • Function arguments are typed
  • Added/modified unit tests to cover changes.
  • New features have documentation added to the docs.
  • New features and backwards compatibility breaks are noted in the RELEASE.md

@debonisd debonisd linked an issue Mar 1, 2024 that may be closed by this pull request
source_url and source_download do not work as expected #711
Open
@debonisd debonisd requested a review from Paul-Ferrell March 1, 2024 20:36
Paul-Ferrell
Paul-Ferrell requested changes Mar 5, 2024
View reviewed changes
lib/pavilion/builder.py Outdated
@@ -319,7 +319,7 @@ def _update_src(self):

if (src_url is not None
and ((src_download == 'missing' and found_src_path is None)
or src_download == 'latest')):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've just changed the behavior of 'latest' such that it is now doing the same as 'missing'. That's not the problem. It seems that the files are getting downloaded, but they're not getting copied into their expected destination where Pavilion can find them.

@Paul-Ferrell
Copy link
Collaborator

This is still an empty merge request...

Paul-Ferrell
Paul-Ferrell previously approved these changes Mar 21, 2024
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Paul-Ferrell Paul-Ferrell Paul-Ferrell left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

source_url and source_download do not work as expected
2 participants
@debonisd @Paul-Ferrell