-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to ignore hardlinks in dsync, dcmp and dwalk #565
base: main
Are you sure you want to change the base?
Conversation
Add flag option nohardlink in mfu_walk_opts_t structure to add the possibility to ignore hardlinks in walk_stat_process() Signed-off-by: Gaël Delbary <[email protected]> Co-authored-by: Gaël Delbary <[email protected]> Signed-off-by: Rémi Palancher <[email protected]>
Add --nohardlink option to ignore hardlink when walking in files tree. This option adds the possibility to avoid copying hardlinks as regular files which could cause significant increase in storage consumption. Users then have the possibility to redefine ignored hardlinks using another mechanism. Signed-off-by: Gaël Delbary <[email protected]> Co-authored-by: Gaël Delbary <[email protected]> Signed-off-by: Rémi Palancher <[email protected]>
Add --nohardlink option to ignore hardlink when walking in files tree. Signed-off-by: Gaël Delbary <[email protected]> Co-authored-by: Gaël Delbary <[email protected]> Signed-off-by: Rémi Palancher <[email protected]>
Add --nohardlink option to ignore hardlink when walking in files tree. Signed-off-by: Gaël Delbary <[email protected]> Co-authored-by: Gaël Delbary <[email protected]> Signed-off-by: Rémi Palancher <[email protected]>
Mention new -H, --nohardlink option in dsync, dcmp and dwalk manpages. Signed-off-by: Rémi Palancher <[email protected]>
Signed-off-by: Rémi Palancher <[email protected]>
Not that if the source filesystem is Lustre and the client is mounted with This would allow efficiently maintaining the hard links in the target filesystem without having to make a full separate copy of the file, or scan the source tree trying to find the links. Alternately, I believe |
Hi @adilger , |
Thanks for the patch @rezib , and thanks for the tip on the Lustre calls for hardlinks @adilger . Yes, this looks simple enough to add, and I understand the need. We could also look to add hardlink support for the copy. I need to think about this more, but I suspect we could support this across file systems in general by using We could perhaps use the Lustre calls as an optimization. This needs to be fleshed out more... Assuming we do that, would this option still be useful in other cases? |
This is a proposal to add
-H, --nohardlink
option ondsync
,dcmp
anddwalk
to ignore hardlinks when walking in files tree.The rationale is to avoid producing multiple copies of the same inodes which could result in synchronized files tree requiring much more storage consumption.
The corresponding manpages are also updated accordingly.