rpm: use %cmake macros #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation about these macros is available in Fedora project packaging guidelines: https://docs.fedoraproject.org/en-US/packaging-guidelines/CMake/ One notable advantage of these macros is that they transparently define compiler and linker flags with distribution defaults. Signed-off-by: Rémi Palancher <[email protected]>
|
Seems to properly fix #547 |
|
One more addition I see in #547 is that it adds some build-time dependencies. I'm guessing those are needed in clean build environments. Would adding those interfere with your build? |
Absolutely not! We added these build requirements as well in our in-house spec file actually. We simply didn't contribute this change as we also include other build requirements that may not be relevant in the general case. Thank you for the merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation about these macros is available in Fedora project packaging guidelines:
https://docs.fedoraproject.org/en-US/packaging-guidelines/CMake/
One notable advantage of these macros is that they transparently define compiler and linker flags with distribution defaults.