Skip to content
This repository has been archived by the owner on Oct 2, 2024. It is now read-only.

fix ObsPy test #1885

Merged
merged 2 commits into from
Mar 28, 2024
Merged

fix ObsPy test #1885

merged 2 commits into from
Mar 28, 2024

Conversation

reidpr
Copy link
Collaborator

@reidpr reidpr commented Mar 27, 2024

ObsPy 1.4.0, which is the current version, is not compatible with Python 3.12. The default Python version in Miniconda recently became Python 3.12, so this test stopped working.

This PR fixes the Miniconda version at 24.1.2 with Python 3.11 to get the test going again for now.

@reidpr reidpr added this to the 0.38 milestone Mar 27, 2024
@reidpr reidpr self-assigned this Mar 27, 2024
@reidpr reidpr requested a review from lucaudill March 28, 2024 15:43
@reidpr
Copy link
Collaborator Author

reidpr commented Mar 28, 2024

Internal tests pass in full scope.

Copy link
Collaborator

@lucaudill lucaudill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reidpr reidpr merged commit 1e1ef74 into master Mar 28, 2024
@reidpr reidpr deleted the obspy-conflict branch March 28, 2024 21:00
kchilleri pushed a commit that referenced this pull request May 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants