Skip to content
This repository has been archived by the owner on Oct 2, 2024. It is now read-only.

ch-convert: add --quiet #1735

Merged
merged 15 commits into from
Nov 1, 2023
Merged

ch-convert: add --quiet #1735

merged 15 commits into from
Nov 1, 2023

Conversation

lucaudill
Copy link
Collaborator

This PR adds a --quiet option to ch-convert to suppress output to stdout and stderr.

@lucaudill lucaudill self-assigned this Oct 2, 2023
@lucaudill lucaudill requested a review from reidpr October 3, 2023 18:22
reidpr
reidpr suggested changes Oct 9, 2023
View reviewed changes
Copy link
Collaborator

@reidpr reidpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want to follow the same scheme as ch-image, i.e. allow repetition of -q and follow the chart in the FAQ.

@lucaudill lucaudill marked this pull request as ready for review October 19, 2023 22:15
@lucaudill lucaudill marked this pull request as draft October 19, 2023 22:15
@lucaudill lucaudill requested a review from reidpr October 31, 2023 18:06
@lucaudill lucaudill marked this pull request as ready for review October 31, 2023 22:07
reidpr
reidpr suggested changes Oct 31, 2023
View reviewed changes
Copy link
Collaborator

@reidpr reidpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Seems very close. Some comments in-line.

bin/ch-convert Outdated Show resolved Hide resolved
bin/ch-convert Outdated Show resolved Hide resolved
bin/ch-convert Outdated Show resolved Hide resolved
bin/ch-convert Outdated Show resolved Hide resolved
lib/base.sh Outdated Show resolved Hide resolved
@lucaudill lucaudill requested a review from reidpr November 1, 2023 17:47
@reidpr reidpr added this to the 0.36 milestone Nov 1, 2023
@reidpr reidpr merged commit c57ba25 into master Nov 1, 2023
6 checks passed
@reidpr reidpr deleted the quiet-convert branch November 1, 2023 19:51
@reidpr reidpr mentioned this pull request Nov 27, 2023
Closed
@lucaudill lucaudill mentioned this pull request Jan 19, 2024
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@reidpr reidpr reidpr approved these changes

Assignees

@lucaudill lucaudill

Labels
enhancement medium misc
Projects
None yet
Milestone
0.36
Development

Successfully merging this pull request may close these issues.
2 participants
@lucaudill @reidpr