Skip to content
This repository has been archived by the owner on Oct 2, 2024. It is now read-only.

RSYNC extension #1708

Merged
merged 23 commits into from
Oct 25, 2023
Merged

RSYNC extension #1708

merged 23 commits into from
Oct 25, 2023

Conversation

reidpr
Copy link
Collaborator

@reidpr reidpr commented Aug 25, 2023

No description provided.

@reidpr reidpr self-assigned this Aug 25, 2023
@reidpr reidpr requested a review from lucaudill August 25, 2023 23:27
lucaudill
lucaudill approved these changes Aug 30, 2023
View reviewed changes
Copy link
Collaborator

@lucaudill lucaudill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a good plan, I'd say go ahead with it

@reidpr reidpr added this to the 0.35 milestone Oct 10, 2023
@reidpr reidpr requested a review from j-ogas October 16, 2023 17:13
j-ogas
j-ogas suggested changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@j-ogas j-ogas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments/questions in-line.

doc/tutorial.rst Outdated Show resolved Hide resolved
doc/tutorial.rst Outdated Show resolved Hide resolved
examples/Dockerfile.almalinux_8ch Show resolved Hide resolved
lib/filesystem.py Outdated Show resolved Hide resolved
test/build/55_cache.bats Outdated Show resolved Hide resolved
test/build/55_cache.bats Show resolved Hide resolved
lib/filesystem.py Show resolved Hide resolved
doc/ch-image.rst Show resolved Hide resolved
@reidpr reidpr requested a review from j-ogas October 19, 2023 20:40
j-ogas
j-ogas suggested changes Oct 23, 2023
View reviewed changes
lib/filesystem.py Outdated Show resolved Hide resolved
@reidpr @j-ogas
typo [skip ci]
2aa8cb3 
Co-authored-by: Jordan Ogas <[email protected]>
@reidpr reidpr requested a review from j-ogas October 24, 2023 02:01
j-ogas
j-ogas approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@j-ogas j-ogas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reidpr reidpr merged commit 6dba8f0 into master Oct 25, 2023
@reidpr reidpr deleted the rsync branch October 25, 2023 16:16
@reidpr reidpr mentioned this pull request Jan 11, 2024
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lucaudill lucaudill lucaudill approved these changes

@j-ogas j-ogas j-ogas approved these changes

Assignees

@reidpr reidpr

Labels
enhancement image medium usability
Projects
None yet
Milestone
0.35
Development

Successfully merging this pull request may close these issues.
3 participants
@reidpr @j-ogas @lucaudill