This repository has been archived by the owner on Oct 2, 2024. It is now read-only.
reprint warnings before exit (ch-run, ch-image)
#1677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reidpr
suggested changes
Aug 18, 2023
reidpr
suggested changes
Aug 30, 2023
test/run/ch-run_misc.bats
Outdated
Comment on lines
1067
to
1069
| # Warnings list is a statically sized memory buffer. Ensure it works as | ||
| # intended by printing more warnings than can be saved to this buffer and | ||
| # checking that the program doesn’t crash. |
There was a problem hiding this comment.
Also validate the number of warnings re-printed.
reidpr
reviewed
Sep 6, 2023
Comment on lines
+1077
to
+1079
| [[ $output == *'ch-run['*']: warning: reprinting first '*' warning(s)'* ]] | ||
| [[ $(echo "$output" | grep -Fc 'this is warning 1!') -eq 2 ]] | ||
| [[ $(echo "$output" | grep -Fc 'this is warning 100!') -eq 1 ]] |
reidpr
approved these changes
Sep 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1674