This repository has been archived by the owner on Oct 2, 2024. It is now read-only.
add -q/--quiet to ch-image
#1636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
reidpr
suggested changes
Jun 2, 2023
lib/charliecloud.py
Outdated
| if (log_quiet > 0): | ||
| fail_ct = 0 | ||
| if (trace_fatal): | ||
| ERROR("“quiet” incompatible with “debug”") |
There was a problem hiding this comment.
Might want to mention the environment variable here too since folks might not make the translation or remember they set it.
Co-authored-by: Reid Priedhorsky <[email protected]>
Co-authored-by: Reid Priedhorsky <[email protected]>
Co-authored-by: Reid Priedhorsky <[email protected]>
Co-authored-by: Reid Priedhorsky <[email protected]>
reidpr
suggested changes
Sep 13, 2023
| @@ -98,13 +101,15 @@ Common options placed before or after the sub-command: | |||
| subprocesses. Profile data should still be written on fatal errors, but | |||
| not if the program crashes. | |||
|
|
|||
| :code:`-q, --quiet` | |||
| Be quieter; can be repeated. Incompatible :code:`-v` and suppresses | |||
| :code:`--debug` regardless of option order. See the :ref:`FAQ entry on | |||
There was a problem hiding this comment.
I wonder if we should revisit the --debug incompatibility? It seems orthogonal now.
Also --debug seems to be undocumented here.
| @@ -1098,6 +1094,153 @@ linuxcontainers.org uses the opposite order for “le” in the architecture nam | |||
| $ wget https://uk.lxd.images.canonical.com/images/alpine/3.15/ppc64el/default/20220304_13:00/rootfs.tar.xz | |||
| $ ch-image import rootfs.tar.xz ppc64le/alpine:3.17 | |||
|
|
|||
| .. _faq_verbosity: | |||
|
|
|||
| How can I control Charliecloud’s quietness or verbosity? | |||
There was a problem hiding this comment.
Say something about Charliecloud's own stdout in this section?
lib/charliecloud.py
Outdated
Comment on lines
650
to
652
| if (cli.verbose): | ||
| ERROR("“quiet” incompatible with “verbose”") | ||
| fail_ct += 1 |
There was a problem hiding this comment.
We could do it where every -v increases verbosity by 1 and every -q decreases it by 1. I wonder if that's too weird though.
Co-authored-by: Reid Priedhorsky <[email protected]>
Co-authored-by: Reid Priedhorsky <[email protected]>
reidpr
approved these changes
Sep 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1613