Skip to content
This repository has been archived by the owner on Nov 22, 2022. It is now read-only.

Commit

Permalink
(ci)Add npm script to run linter (#165)
Browse files Browse the repository at this point in the history
* (ci)Add npm script to run linter

This branch adds the ability to check linting by running `npm run lint`.

The configuration is present at `.eslintrc` and focuses on the
directories: src/ and test/

Future change: run it as a job with Travis CI.

* (ci)add linting to travis

* (core) undo changes for build/ file

* (chore) change eslint to run with an allow list
  • Loading branch information
elfrank authored Oct 5, 2020
1 parent 02281f2 commit ea68d04
Show file tree
Hide file tree
Showing 8 changed files with 571 additions and 14 deletions.
10 changes: 9 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,12 @@ before_script:
- chmod +x ./cc-test-reporter
- ./cc-test-reporter before-build
after_script:
- ./cc-test-reporter after-build --exit-code $TRAVIS_TEST_RESULT
- ./cc-test-reporter after-build --exit-code $TRAVIS_TEST_RESULT
jobs:
include:
- stage: test
name: "Unit Tests"
script: npm run test
- stage: check
name: "Linting"
script: npm run lint
1 change: 0 additions & 1 deletion PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,5 @@ TODO or DELETE
- [ ] All existing tests passed.
- [ ] I have added tests to cover my changes, of which pass.
- [ ] I have [compared](https://github.com/hoverinc/ray-tracing-renderer/wiki/Contributing#comparing-changes) the render output of my branch to `master`.
- [ ] My code has passed the ESLint configuration for this project.
- [ ] My change requires modifications to the documentation.
- [ ] I have updated the documentation accordingly.
Loading

0 comments on commit ea68d04

Please sign in to comment.