[Jormungandr] Implement pt journey fare #4089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xlqian
force-pushed
the
jormungandr_implement_pt_journey_fare
branch
from
6b84f85
to
503c707
Compare
xlqian
force-pushed
the
jormungandr_implement_pt_journey_fare
branch
3 times, most recently
from
0bbb49b
to
00f9d42
Compare
pbougue
approved these changes
Sep 18, 2023
There was a problem hiding this comment.
After discussion, the assumed behavior for this feature is gonna be:
"trigger (or not) a fare-computation, no matter if it was already computed".
Which means that the trigger-fare and pt-journey planner params will have to be maintained/used at the same time.
So it may lead to (bold are "weird" but assumed):
- double fares in result (case of Kraken journey + trigger)
- single fares in result (case of Loki journey + trigger, or Kraken + no-trigger)
- no fares in result (case of Loki journey + no-trigger).
This explains:
source/jormungandr/jormungandr/pt_journey_fare/pt_journey_fare.py
Outdated
Show resolved
Hide resolved
source/jormungandr/jormungandr/pt_journey_fare/pt_journey_fare.py
Outdated
Show resolved
Hide resolved
xlqian
force-pushed
the
jormungandr_implement_pt_journey_fare
branch
from
e60378f
to
22902c1
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.