[Kraken] change the way journey's status is computed #4086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 7, 2023 12:54
Sometimes none is available because the whole VJ is removed. So getting the freshest returns a VJ unusable in RT. Fixes almost "invisible" bug in #3995: case of a trip being canceled by a disruption without NO_SERVICE effect (see fixed test).
Not taking into consideration the effect of disruptions associated, just the actual effect on pick-ups and drop-offs used by the journey. Also: * Update doc accordingly * Update the conditions to add "bypass_disruptions" link * Just update tests impacted by the change TODO (next commit): * Add tests on SIGNIFICANT_DELAYS status (with bypass_disruptions link) https://navitia.atlassian.net/wiki/spaces/NAV/pages/7024845232/Interfaces+v1+temps+r+el#Status-global-d%E2%80%99un-journey JIRA: https://navitia.atlassian.net/browse/NAV-2129 For the record, already existing tests (after fix): * Status empty with no disruption at all: routing_api_test.cpp:896 + kirin_realtime_tests.py:3750 + 4037 + 4193 * Status empty with disruption on line and stop (no actual effect): routing_api_test.cpp:1987 * Status empty with disruption on network and stop (no actual effect): routing_api_test.cpp:2037 * bypass_disruptions link with NO_SERVICE status (disruption blocking stop): chaos_disruptions_tests.py:555 * NO_SERVICE with blocking disruption on line: chaos_disruptions_tests.py:949 * MODIFIED_SERVICE after stop-add: kirin_realtime_tests.py:977 * MODIFIED_SERVICE after DETOUR (using added stop): kirin_realtime_tests.py:1734 * MODIFIED_SERVICE after trip-add: kirin_realtime_tests.py:1906 + 2720 + 2855 * NO_SERVICE after rail-section DETOUR (using blocked stop): kirin_realtime_tests.py:3544 * NO_SERVICE after disruption REDUCED_SERVICE (using deleted stop): kirin_realtime_tests.py:3673 * Status empty with REDUCED_SERVICE on other stops: kirin_realtime_tests.py:3682 * NO_SERVICE after NO_SERVICE disruption on stop_area: kirin_realtime_tests.py:3723 * NO_SERVICE (adapted journey) after REDUCED_SERVICE disruption (using deleted stop): kirin_realtime_tests.py:3889 * Status empty after NO_SERVICE disruption on passing stop_area: kirin_realtime_tests.py:3731 * Status empty after NO_SERVICE rail_section disruption and a kirin REDUCED_SERVICE that "unlock" the end of the trip: kirin_realtime_tests.py:3964 * NO_SERVICE after NO_SERVICE rail_section disruption: kirin_realtime_tests.py:4115 + 4122
Also add a test on a journey having both deleted and delayed stops
* handle C++ warning * typo
|
Kudos, SonarCloud Quality Gate passed!
|
pbench
approved these changes
Aug 10, 2023
pbougue
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 please review by commit with comment.
Stop taking into consideration the effect of disruptions associated, just consider the actual effect on pick-ups and drop-offs used by the journey.
Also:
Doc: https://navitia.atlassian.net/wiki/spaces/NAV/pages/7024845232/Interfaces+v1+temps+r+el#Status-global-d%E2%80%99un-journey
JIRA: https://navitia.atlassian.net/browse/NAV-2129