Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct ami percentage in csv (#4520) #827

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ludtkemorgan
Copy link
Collaborator

This PR addresses bloom-housing#1027

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

The listing units csv export is displaying the incorrect AMI Chart percentage. It is grabbing the first value from the amiChart instead of getting the percentage off of the unit table

Note:

  • There are currently no tests that cover the CSV export. I have added a test as part of this change, but only test the unit CSV. More tests should be added

How Can This Be Tested/Reviewed?

After a clean reseed In the partner site click the "Export to CSV" button on the listings page and compare the values to the listings

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

* fix: use correct ami percentage in csv

* fix: add unit test
@ludtkemorgan ludtkemorgan added 1 review needed release A PR that is pulling over a commit(s) from core labels Jan 3, 2025
Copy link

netlify bot commented Jan 3, 2025

Deploy Preview for housing-sanjoseca-gov ready!

Name Link
🔨 Latest commit e4f09c6
🔍 Latest deploy log https://app.netlify.com/sites/housing-sanjoseca-gov/deploys/67782c97f8bdaf000815b010
😎 Deploy Preview https://deploy-preview-827--housing-sanjoseca-gov.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@mcgarrye mcgarrye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge release A PR that is pulling over a commit(s) from core
Development

Successfully merging this pull request may close these issues.

2 participants