Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: feature flag script #823

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

mcgarrye
Copy link
Collaborator

@mcgarrye mcgarrye commented Dec 12, 2024

This PR addresses #(4460)

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

This script will create the 16 feature flags in use across Core, HBA and Doorway in each database. Each has a simplified name, a readable description and is set to false. Following release and running of this script, the API must be called to associate the needed jurisdictions.

Related links:
Notion Documentation
Existing Flags Sheet

How Can This Be Tested/Reviewed?

  • Run yarn setup
  • Start up backend
  • Sign in as an admin to the API
  • Call /scriptRunner/addFeatureFlags
  • Check console logs for success of all 16 flags
  • Call GET featureFlags/ to retrieve list of featureFlags

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

mcgarrye and others added 2 commits December 12, 2024 12:58
* feat: adjust update functionality

* feat: create feature flag script

4460

* feat: remove deprecated flags

* feat: remove soon to be deprecated flag

* feat: add description

* feat: include enablePartnerSettings

4460
@mcgarrye mcgarrye added 1 review needed release A PR that is pulling over a commit(s) from core labels Dec 12, 2024
Copy link

netlify bot commented Dec 12, 2024

Deploy Preview for housing-sanjoseca-gov ready!

Name Link
🔨 Latest commit 1364bb1
🔍 Latest deploy log https://app.netlify.com/sites/housing-sanjoseca-gov/deploys/6761dbfb2240390008bb45f5
😎 Deploy Preview https://deploy-preview-823--housing-sanjoseca-gov.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ColinBuyck
Copy link
Collaborator

@mcgarrye I'm seeing 16 feature flags created rather than 15. Is that expected?
Screenshot 2024-12-17 at 10 01 10 AM

@mcgarrye
Copy link
Collaborator Author

@mcgarrye I'm seeing 16 feature flags created rather than 15. Is that expected? Screenshot 2024-12-17 at 10 01 10 AM

yes, typo in the qa note

Copy link
Collaborator

@ColinBuyck ColinBuyck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥅 but could you rerun tests to ensure the failure is flakiness

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge release A PR that is pulling over a commit(s) from core
Development

Successfully merging this pull request may close these issues.

2 participants