Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: building selection criteria adjustment (#4505) #822

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

mcgarrye
Copy link
Collaborator

@mcgarrye mcgarrye commented Dec 12, 2024

This PR addresses #(982)

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

Listings with a BuildingSelectionCriteriaFile could not be duplicated due to an issue re-creating the asset. This is fixed by not passing the existing asset id to the new copy.

How Can This Be Tested/Reviewed?

  • Create or edit a listing to have a building selection criteria file.
  • Copy the listing
  • Confirm the building selection criteria file is present on the copy listing
  • Publish the copy listing
  • Go to the public site, view the copy listing, view the building selection criteria file

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

@mcgarrye mcgarrye added 1 review needed release A PR that is pulling over a commit(s) from core labels Dec 12, 2024
Copy link

netlify bot commented Dec 12, 2024

Deploy Preview for housing-sanjoseca-gov ready!

Name Link
🔨 Latest commit 3e7f3c7
🔍 Latest deploy log https://app.netlify.com/sites/housing-sanjoseca-gov/deploys/675b202be4e4680008fd4be8
😎 Deploy Preview https://deploy-preview-822--housing-sanjoseca-gov.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@ColinBuyck ColinBuyck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍯

@mcgarrye mcgarrye merged commit 7cdb90e into main Dec 17, 2024
37 checks passed
@mcgarrye mcgarrye deleted the release/duplicate-building-selection-issue branch December 17, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release A PR that is pulling over a commit(s) from core
Development

Successfully merging this pull request may close these issues.

2 participants