Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: community type disclaimer #821

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: community type disclaimer #821

wants to merge 3 commits into from

Conversation

KrissDrawing
Copy link
Collaborator

This PR addresses #4476 #4477

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

Release of community disclaimer This core PR.
Also includes backend bart

How Can This Be Tested/Reviewed?

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

YazeedLoonat and others added 3 commits December 12, 2024 15:49
@YazeedLoonat @KrissDrawing
feat: adding community type disclaimer fields (bloom-housing#4486)
cc2b7b8 
* feat: adding community type disclaimer fields

* fix: updates per morgan

(cherry picked from commit baa2f43)
@KrissDrawing
fix: community type disclaimer frontend (bloom-housing#4496)
c7fdafa 
* fix: add community type disclaimer to public site

* fix: add community type disclaimer to partners

* fix: add partners tests

* fix: form type issue

* fix: failing build

* fix: allow reserved community disclaimer only when community type selected

* fix: tests

* fix: be tests

* fix: add translations with tests

(cherry picked from commit 2769691)
@KrissDrawing
chore: generate client
674661f
@KrissDrawing KrissDrawing added 1 review needed release A PR that is pulling over a commit(s) from core labels Dec 12, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 12, 2024 •
edited
Loading

✅ Deploy Preview for housing-sanjoseca-gov ready!

Name Link
🔨 Latest commit 674661f
🔍 Latest deploy log https://app.netlify.com/sites/housing-sanjoseca-gov/deploys/675afdbacf00260008be6ab0
😎 Deploy Preview https://deploy-preview-821--housing-sanjoseca-gov.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1 review needed release A PR that is pulling over a commit(s) from core
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KrissDrawing @YazeedLoonat