Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: feature flag consumption (#4489) #820

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

mcgarrye
Copy link
Collaborator

This PR addresses #(4459)

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

Creates the module, controller and service files for the new Feature Flag table. Allows for standard CRUD methods, as well as a list endpoint and an endpoint to add/remove jurisdiction associations with the flag (associateJurisdictions). Permissions are limited to admin only. Flags associated with jurisdictions will appear when jurisdiction data is returned.

How Can This Be Tested/Reviewed?

Start up the backend. Login as an admin, either through the API or partners portal. Test each endpoint:

  • Create a feature flag
  • Get the feature flag using the id returned ^^
  • Update the feature flag using the id
  • Get the feature flag to verify update
  • Associate jurisdiction(s) with the flag
  • Get the feature flag to verify association
  • Get the jurisdiction to verify association
  • Call the list endpoint
  • Remove the jurisdiction(s) using associateJurisdictions
  • Get the feature flag to verify removal
  • Get the jurisdiction to verify removal
  • Delete feature flag
  • Call list endpoint to verify

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

* feat: feature flag controller service and tests

4459

* feat: associate jurisdictions tests

* feat: permissions and permission tests

* feat: make naming random

* feat: edge case coverage

* feat: refine uuid array validation

* feat: remove unused import

* feat: controller cleanup
@mcgarrye mcgarrye added 1 review needed release A PR that is pulling over a commit(s) from core labels Nov 27, 2024
Copy link

netlify bot commented Nov 27, 2024

Deploy Preview for housing-sanjoseca-gov ready!

Name Link
🔨 Latest commit 8c336d6
🔍 Latest deploy log https://app.netlify.com/sites/housing-sanjoseca-gov/deploys/6747353cc8860c00083f462f
😎 Deploy Preview https://deploy-preview-820--housing-sanjoseca-gov.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@ludtkemorgan ludtkemorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦃

@mcgarrye mcgarrye merged commit 5261ae8 into main Dec 2, 2024
37 checks passed
@mcgarrye mcgarrye deleted the release/feature-flag-controller branch December 2, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release A PR that is pulling over a commit(s) from core
Development

Successfully merging this pull request may close these issues.

2 participants