release: date field validation and application due date changes #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m-housing#4331) * feat: improve client-side field validation on Partners listings * feat: additional error reporting * fix: make lottery dates/times required * fix: use time error values for time fields * test: update demographics queries not to use title attribute (cherry picked from commit 94b4ef3)
…m-housing#4417) * feat: add validation for application due date but not on open waitlist * fix: refactor logic of the validator * test: add due date entry * test: fix lexical scope issue * test: ensure app due date is always filled out * chore: add comments (cherry picked from commit fe9a1dd)
✅ Deploy Preview for housing-sanjoseca-gov ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
* fix: allow a due date for open waitlist * fix: allow a due date for all listing types * fix: remove due date choice field (cherry picked from commit eb912ea)
|
Generally seems to be working. However, I do notice a difference from core with the date validations. In core you can't even type non-numeric characters, but I am able to do so locally for this branch. Any clue why? |
|
@jaredcwhite Flagging this open question from Eric! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pulls in the following Core PRs: