Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove env variable dependencies from tests (bloom-housing#4471) #817

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ludtkemorgan
Copy link
Collaborator

Pulls over the following two commits from core:

Note:

  • This will not have any noticeable changes in the UI, but tests should still pass

* fix: add bengali localization

* fix: add bengali locale to all languages

* fix: add arabic translations

* fix: add arabic to other locales

* fix: update getfeedback translation
@ludtkemorgan ludtkemorgan added 1 review needed release A PR that is pulling over a commit(s) from core labels Nov 26, 2024
Copy link

netlify bot commented Nov 26, 2024

Deploy Preview for housing-sanjoseca-gov ready!

Name Link
🔨 Latest commit 843139b
🔍 Latest deploy log https://app.netlify.com/sites/housing-sanjoseca-gov/deploys/6745200d433cde0008ca5656
😎 Deploy Preview https://deploy-preview-817--housing-sanjoseca-gov.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

API_PASS_KEY: "some-key-here"
HOUSING_COUNSELOR_SERVICE_URL: "/get-assistance"
# Sample token https://docs.mapbox.com/api/accounts/tokens/#example-token-metadata-object
MAPBOX_TOKEN: "pk.eyJ1Ijoic2NvdGhpcyIsImEiOiJjaWp1Y2ltYmUwMDBicmJrdDQ4ZDBkaGN4In0.sbihZCZJ56-fsFNKHXF8YQ"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ludtkemorgan Is this a private var?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a sample token stolen from the commented link. The API needs a valid looking token (starting with pk. and probably a few other things) but it's not actually a valid token that would work if you tried to use it

Copy link
Collaborator

@ColinBuyck ColinBuyck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🪀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge release A PR that is pulling over a commit(s) from core
Development

Successfully merging this pull request may close these issues.

3 participants