Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduce the view for user edit #810

Merged
merged 1 commit into from
Nov 15, 2024
Merged

fix: reduce the view for user edit #810

merged 1 commit into from
Nov 15, 2024

Conversation

ludtkemorgan
Copy link
Collaborator

@ludtkemorgan ludtkemorgan commented Nov 15, 2024

This PR addresses #(insert-number-here)

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

When attempting to edit a user we do a call to get a list of all of the listings. This is for the displaying of the listing checkboxes. However, there are now too many listings in HBA and the response is too big for Netlify to return. This is an extra big response because we are returning way more values of the listings than what is needed.

This PR changes the requested view from "base" to "fundamentals" so units data is not returned.

Long term we should also create a view that only has ids and names.

How Can This Be Tested/Reviewed?

Editing a partner user should still work

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

Copy link

netlify bot commented Nov 15, 2024

Deploy Preview for housing-sanjoseca-gov ready!

Name Link
🔨 Latest commit cd1a161
🔍 Latest deploy log https://app.netlify.com/sites/housing-sanjoseca-gov/deploys/6737a0872dcd740008f3e7e4
😎 Deploy Preview https://deploy-preview-810--housing-sanjoseca-gov.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@YazeedLoonat YazeedLoonat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I do think if we needed to we could cut this down with a new view or one where instead of something like jursidictions: true we specify the fields we are selecting to cut it down even further

@YazeedLoonat YazeedLoonat merged commit 843fbc1 into main Nov 15, 2024
37 checks passed
@YazeedLoonat YazeedLoonat deleted the 4481/user-edit branch November 15, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants