-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: correction script for sparks homes application preferences #795
Conversation
✅ Deploy Preview for housing-sanjoseca-gov ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, some changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR addresses #(794)
Description
Script collects the existing applications to Sparks Homes and updates the preferences jsonb for each application with corrected options strings.
How Can This Be Tested/Reviewed?
Pull down prob db copy from Heroku and setup locally.
Check the preferences field for applications associated with listing id 'a055ce66-a074-4f3a-b67b-6776bec9926e'
Start app, sign in as an admin through partner portal or api.
Through the api, call
/scriptRunner/correctApplicationPreferenceDataForSparksHomes
.Check the preferences field for applications associated with listing id 'a055ce66-a074-4f3a-b67b-6776bec9926e'
and assert update worked.
query:
SELECT preferences FROM applications WHERE listing_id='a055ce66-a074-4f3a-b67b-6776bec9926e';
Author Checklist:
yarn generate:client
and/or created a migration when requiredReview Process: