Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: correction script for sparks homes application preferences #795

Merged
merged 3 commits into from
Oct 29, 2024

Conversation

mcgarrye
Copy link
Collaborator

@mcgarrye mcgarrye commented Oct 28, 2024

This PR addresses #(794)

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

Script collects the existing applications to Sparks Homes and updates the preferences jsonb for each application with corrected options strings.

How Can This Be Tested/Reviewed?

Pull down prob db copy from Heroku and setup locally.
Check the preferences field for applications associated with listing id 'a055ce66-a074-4f3a-b67b-6776bec9926e'
Start app, sign in as an admin through partner portal or api.
Through the api, call /scriptRunner/correctApplicationPreferenceDataForSparksHomes.
Check the preferences field for applications associated with listing id 'a055ce66-a074-4f3a-b67b-6776bec9926e'
and assert update worked.

query:
SELECT preferences FROM applications WHERE listing_id='a055ce66-a074-4f3a-b67b-6776bec9926e';

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

@mcgarrye mcgarrye closed this Oct 28, 2024
@mcgarrye mcgarrye reopened this Oct 28, 2024
Copy link

netlify bot commented Oct 28, 2024

Deploy Preview for housing-sanjoseca-gov ready!

Name Link
🔨 Latest commit 53265f5
🔍 Latest deploy log https://app.netlify.com/sites/housing-sanjoseca-gov/deploys/67211c9f962785000837cd9a
😎 Deploy Preview https://deploy-preview-795--housing-sanjoseca-gov.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@ludtkemorgan ludtkemorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧩

api/src/services/script-runner.service.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@YazeedLoonat YazeedLoonat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, some changes

api/src/services/script-runner.service.ts Outdated Show resolved Hide resolved
api/src/services/script-runner.service.ts Outdated Show resolved Hide resolved
@mcgarrye mcgarrye requested a review from YazeedLoonat October 29, 2024 17:34
Copy link
Collaborator

@YazeedLoonat YazeedLoonat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcgarrye mcgarrye merged commit eb608f5 into main Oct 29, 2024
45 checks passed
@mcgarrye mcgarrye deleted the feat/preference_correction_script branch October 29, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high priority
Development

Successfully merging this pull request may close these issues.

3 participants