Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: add farmworkerHousing and update other translations (#4415) #793

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

mcgarrye
Copy link
Collaborator

This PR addresses #(910)

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

This adds the farmworkerHousing translations needed for Doorway. It also corrects the plural versions of a few reservedCommunityTypeDescriptions and the traditional Chinese translations for some cases.
Added examples for the createNewReservedCommunityType endpoint to make clear what is needed in the fields.

How Can This Be Tested/Reviewed?

  1. Reseed the backend and start it up
  2. Log in as a admin user (either through the partner UI or directly in the swagger doc)
  3. In the swagger doc http://localhost:3100/api#/scriptRunner/createNewReservedCommunityType run the script 3 times using the following data:
    {
    id : jurisdiction id (need to get it from the db)
    name: "farmworkerHousing"
    description: "Employee of the school district"
    }
    {
    id : jurisdiction id (need to get it from the db)
    name: "schoolEmployee"
    description: "Farmworkers and Their Families"
    }
    {
    id : jurisdiction id (need to get it from the db)
    name: "housingVoucher"
    description: "HCV/Section 8 Voucher Holders"
    }
  4. The new community type should be in the database and also selectable in the partner UI
  5. Test each of the above by adding them to a listing in the assigned jurisdiction and toggling the language
  6. Additionally test in the same way the Veteran reservedCommunityType

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

@mcgarrye mcgarrye added 1 review needed release A PR that is pulling over a commit(s) from core labels Oct 24, 2024
Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for housing-sanjoseca-gov ready!

Name Link
🔨 Latest commit 42ad32a
🔍 Latest deploy log https://app.netlify.com/sites/housing-sanjoseca-gov/deploys/672246c59a9f6d0008fa5bd4
😎 Deploy Preview https://deploy-preview-793--housing-sanjoseca-gov.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@emilyjablonski emilyjablonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐩

@mcgarrye mcgarrye merged commit d0e639f into main Oct 30, 2024
45 checks passed
@mcgarrye mcgarrye deleted the release/farmworker-housing-translations branch October 30, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release A PR that is pulling over a commit(s) from core
Development

Successfully merging this pull request may close these issues.

2 participants