Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add all of the jurisdiction data to external #672

Merged
merged 2 commits into from
Feb 28, 2024
Merged

fix: add all of the jurisdiction data to external #672

merged 2 commits into from
Feb 28, 2024

Conversation

ludtkemorgan
Copy link
Collaborator

@ludtkemorgan ludtkemorgan commented Feb 28, 2024 •
edited
Loading

Pull Request Template

Issue Overview

This PR addresses #495

  • This change addresses the issue in full
  • This change addresses only certain aspects of the issue
  • This change is a dependency for another issue
  • This change has a dependency from another issue

Description

Doorway relies on our site for data from the HBA sites. And as part of that it also links back to HBA for the application flow. With the latest Prisma change we slimmed down the jurisdiction data returned on listings and the url link for the jurisdiction is no longer returned

To solve this on the external endpoint we need to add the publicUrl field to the jurisdiction on the new /external endpoint

How Can This Be Tested/Reviewed?

Provide instructions so we can review.

Describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration.

Checklist:

  • My code follows the style guidelines of this project
  • I have added QA notes to the issue with applicable URLs
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have run yarn generate:client and/or created a migration if I made backend changes that require them
  • My commit message(s) is/are polished, and any breaking changes are indicated in the message and are well-described
  • Commits made across packages purposefully have the same commit message/version change, else are separated into different commits

Reviewer Notes:

Steps to review a PR:

  • Read and understand the issue, and ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Also review the acceptance criteria on the Netlify deploy preview (noting that these do not yet include any backend changes made in the PR)
  • Either explicitly ask a clarifying question, request changes, or approve the PR if there are small remaining changes but the PR is otherwise good to go

On Merge:

If you have one commit and message, squash. If you need each message to be applied, rebase and merge.

@netlify Netlify
Copy link

netlify bot commented Feb 28, 2024 •
edited
Loading

✅ Deploy Preview for housing-sanjoseca-gov ready!

Name Link
🔨 Latest commit 6ce74ec
🔍 Latest deploy log https://app.netlify.com/sites/housing-sanjoseca-gov/deploys/65dfb14df6364000088d1f27
😎 Deploy Preview https://deploy-preview-672--housing-sanjoseca-gov.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ludtkemorgan ludtkemorgan marked this pull request as ready for review February 28, 2024 20:45
YazeedLoonat
YazeedLoonat approved these changes Feb 28, 2024
View reviewed changes
Copy link
Collaborator

@YazeedLoonat YazeedLoonat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

YazeedLoonat
YazeedLoonat requested changes Feb 28, 2024
View reviewed changes
Copy link
Collaborator

@YazeedLoonat YazeedLoonat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question

@YazeedLoonat YazeedLoonat self-requested a review February 28, 2024 22:43
YazeedLoonat
YazeedLoonat approved these changes Feb 28, 2024
View reviewed changes
Copy link
Collaborator

@YazeedLoonat YazeedLoonat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ludtkemorgan ludtkemorgan merged commit e2962a1 into main Feb 28, 2024
45 checks passed
@YazeedLoonat YazeedLoonat mentioned this pull request Mar 5, 2024
Merged
YazeedLoonat added a commit that referenced this pull request Mar 14, 2024
@YazeedLoonat @ludtkemorgan
feat: fixes from hba into core (bloom-housing#3910)
71c8a12 
* fix: limit the characters for name on user (#667)

* fix: fixes password out of date error messaging (#669)

* fix: fixes password out of date error messaging

* fix: prod error fixes

* fix: test fix

* fix: public site fix take 2 (#670)

* feat: new endpoint, forgot pwd fix (#671)

* feat: new endpoint, forgot pwd fix

* feat: using new endpoint to public

* fix: update per morgan

* fix: updates to pr

* fix: new test to get us over coverage

* fix: update per morgan

* fix: add all of the jurisdiction data to external (#672)

* fix: add all of the jurisdiction data to external

* fix: use correct field name

* fix: add security around application list (#674)

* fix: add security around application list

* fix: test fixes

* fix: coverage requirement drop

---------

Co-authored-by: Morgan Ludtke <[email protected]>
YazeedLoonat added a commit that referenced this pull request Mar 15, 2024
@YazeedLoonat @ludtkemorgan
@KrissDrawing @jaredcwhite @cade-exygy @ColinBuyck @dependabot @emilyjablonski @mcgarrye
Release 03-14-2024 (#678)
7e5d969 
* fix: null check on option links (bloom-housing#3897)

* fix: adjust spacing for preference application checkboxes (bloom-housing#3868)

* feat: limit user names allowed (bloom-housing#3908)

* fix: the Save and Return link should only show after the Review step has been reached (bloom-housing#3901)

* fix: 3898/passwordless schema changes (bloom-housing#3902)

* feat: mfaCode -> singleUseCode

* feat: adding new field to jurisdiction

* fix: call submit directly from onClick (bloom-housing#3907)

* feat: single use code request endpoint (bloom-housing#3915)

* feat: single use code request endpoint

* fix: updating mocks

* fix: update per Em and Emily

* fix: updates after convo with eric

* fix: updates to tests

* fix: export activity interceptor (bloom-housing#3926)

* fix: export activity interceptor

* fix: import path

* fix: improve export logging tests

* fix: tidy up implementation

* fix: commenting for clarity

* fix: user update/create fixes (bloom-housing#3932)

* feat: fixes from hba into core (bloom-housing#3910)

* fix: limit the characters for name on user (#667)

* fix: fixes password out of date error messaging (#669)

* fix: fixes password out of date error messaging

* fix: prod error fixes

* fix: test fix

* fix: public site fix take 2 (#670)

* feat: new endpoint, forgot pwd fix (#671)

* feat: new endpoint, forgot pwd fix

* feat: using new endpoint to public

* fix: update per morgan

* fix: updates to pr

* fix: new test to get us over coverage

* fix: update per morgan

* fix: add all of the jurisdiction data to external (#672)

* fix: add all of the jurisdiction data to external

* fix: use correct field name

* fix: add security around application list (#674)

* fix: add security around application list

* fix: test fixes

* fix: coverage requirement drop

---------

Co-authored-by: Morgan Ludtke <[email protected]>

* fix: load shared helpers tailwind (bloom-housing#3929)

* fix: update to correct juris on change requested (bloom-housing#3934)

* fix: include demographics in partners applicant csv export  (bloom-housing#3933)

* fix: add flag to include demographics for partners

* refactor: change migration folder name

* chore(deps): bump ip from 1.1.5 to 1.1.9 (bloom-housing#3895)

* refactor: uptake and merge card (bloom-housing#3922)

* fix: underscores in translations (bloom-housing#3925)

* fix: limit requestedChangesUser in Listings response (bloom-housing#3921)

* feat: connect up requsted changes user properly

* fix: limit requestedChangesUser in Listings response

bloom-housing#3889

* fix: update api service unit tests

bloom-housing#3889

* fix: add details view unit test

bloom-housing#3889

* fix: send id and name

bloom-housing#3889

* fix: correct inport statement

* fix: addressing comments

bloom-housing#3889

* fix: cleanup swagger changes

bloom-housing#3889

* fix: add missing return statement

bloom-housing#3889

---------

Co-authored-by: Eric McGarry <[email protected]>

* feat: security patch (bloom-housing#3946)

* feat: security patch

* fix: update per eric

* feat: 3909/add redirect url prisma (bloom-housing#3938)

* feat: get email url from getPublicEmailURL

* fix: handle undefined url case and simplify parsing

* fix: use only baseUrl in welcome and password emails

* fix: fix test

* feat: new single use code login endpoint (bloom-housing#3928)

* feat: new single use code login endpoint

* fix: updates per pr comments

* fix: update seeds + fix listing delete (bloom-housing#3940)

* feat: unconfirmed user login error fix (bloom-housing#3949)

* feat: unconfirmed user login error fix

* fix: unconfirmed user attempting to login, public user logging into partner site, seeding es

* updates per cade

* fix: undefined check

* Merge remote-tracking branch 'origin/main' into security-patch-2

* fix: merge mistakes were made

---------

Co-authored-by: Cade Wolcott <[email protected]>

---------

Co-authored-by: Morgan Ludtke <[email protected]>
Co-authored-by: Krzysztof Zięcina <[email protected]>
Co-authored-by: Jared White <[email protected]>
Co-authored-by: cade-exygy <[email protected]>
Co-authored-by: ColinBuyck <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Emily Jablonski <[email protected]>
Co-authored-by: Eric McGarry <[email protected]>
Co-authored-by: Cade Wolcott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YazeedLoonat YazeedLoonat YazeedLoonat approved these changes

Assignees
No one assigned
Labels
ready to merge
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ludtkemorgan @YazeedLoonat