-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: merge prisma backend #664
Conversation
- @bloom-housing/[email protected] - @bloom-housing/[email protected] - @bloom-housing/[email protected] - @bloom-housing/[email protected]
* chore: update the token usage in the Next.js apps * chore: additional token updates * chore: additional token updates * chore: Update to latest ui-components release * chore: update uic in shared-helpers too * chore: move some components to shared helpers * fix: TypeScript errors * fix: additional TS errors * chore: remove a couple of any typings * fix: cast unknown type to string
- @bloom-housing/[email protected] - @bloom-housing/[email protected] - @bloom-housing/[email protected]
* feat: resetting migrations
- @bloom-housing/[email protected] - @bloom-housing/[email protected] - @bloom-housing/[email protected] - @bloom-housing/[email protected]
- @bloom-housing/[email protected] - @bloom-housing/[email protected] - @bloom-housing/[email protected] - @bloom-housing/[email protected]
* test: add unit tests on the ListingView component * chore: make date variables consistent * test: remove afterEach line
- @bloom-housing/[email protected] - @bloom-housing/[email protected] - @bloom-housing/[email protected]
…g#3257) Bumps [class-validator](https://github.com/typestack/class-validator) from 0.12.2 to 0.14.0. - [Release notes](https://github.com/typestack/class-validator/releases) - [Changelog](https://github.com/typestack/class-validator/blob/develop/CHANGELOG.md) - [Commits](typestack/class-validator@v0.12.2...v0.14.0) --- updated-dependencies: - dependency-name: class-validator dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
- @bloom-housing/[email protected] - @bloom-housing/[email protected] - @bloom-housing/[email protected] - @bloom-housing/[email protected]
* feat: upgrade to node 19 and next 12 * fix: add netlify plugin * fix: add netlify plugin partners * fix: remove netlify plugins * fix: add netlify plugin to toml * Revert "fix: remove netlify plugins" This reverts commit 840b4a1. * fix: switch to node 16 * fix: update all places referencing node * Revert "fix: update all places referencing node" This reverts commit 9f13a5a. * Revert "fix: switch to node 16" This reverts commit 8acbfbe. * fix: re-installed with 18
- @bloom-housing/[email protected] - @bloom-housing/[email protected] - @bloom-housing/[email protected] - @bloom-housing/[email protected]
* feat: add user csv export * fix: remove test logic from auth context * fix: change dates to add time * fix: add success message and more tests * fix: remove only from test file
- @bloom-housing/[email protected] - @bloom-housing/[email protected] - @bloom-housing/[email protected] - @bloom-housing/[email protected]
- @bloom-housing/[email protected] - @bloom-housing/[email protected] - @bloom-housing/[email protected]
- @bloom-housing/[email protected] - @bloom-housing/[email protected] - @bloom-housing/[email protected] - @bloom-housing/[email protected]
* fix: user export fixes * fix: update error message alert
- @bloom-housing/[email protected]
* feat: upgrade react to 18 * feat: upgrade cypress to 12 for public * feat: upgrade cypress for partners * fix: update configs * fix: update partner cypress tests * fix: review comments * fix: fix flaky cypress test
- @bloom-housing/[email protected] - @bloom-housing/[email protected] - @bloom-housing/[email protected] - @bloom-housing/[email protected]
* fix: program/preference keys length uncap * fix: updates per pr comments
- @bloom-housing/[email protected] - @bloom-housing/[email protected] - @bloom-housing/[email protected] - @bloom-housing/[email protected]
* feat: upgrade nextjs to 13 * fix: attempt to get cypress test working
- @bloom-housing/[email protected] - @bloom-housing/[email protected]
cab0e59
to
c2df06b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fantastic!
Only thing I found was:
the user export seems to have a problem where it both doesn't download in the web browser and also doesn't actually send an email out
@YazeedLoonat The email of the user export should be working. Are you logged in with an account to your email and not the admin account? |
* feat: external listing endpoint * fix: adding some tests (temp endpoint so quick tests) * fix: update per morgan
416c0ff
to
42d26c6
Compare
42d26c6
to
78976dd
Compare
|
||
const ApplicationPreferencesAll = () => { | ||
const { listing } = useFormConductor("preferences") | ||
const { listing } = useFormConductor("preferencesAll") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know where this change is coming from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm trying to get the cypress tests to pass and this was a theory since I get a warning about "There is no step defined which matches preferences". That did not solve the issue of running the cypress tests in ci so I'll remove it. But it is a warning that we might want to address at some point.
For the cypress issue. It appears that for some reason only one of the two address verification steps is happening on circleCi when both of them happen when running locally. And they work correctly in Core. So still digging into it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I reverted this change and I got the cypress public test working. I don't know why it was working locally but it was an issue with additional data in the application data for the cypress test.
65100f5
to
573f2c8
Compare
573f2c8
to
fcca33e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ludtkemorgan :sigh: I created a user for myself then forgot to use that user
whoever own [email protected] got a whole bunch of user exports lol
giving this the approval from me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🕹️ Thanks for the clarification @YazeedLoonat!
Pull Prisma changes over to HBA
Description
This pulls all of the changes from core into HBA. A majority of this is the Prisma changes, but there are a few changes that are in core and not yet here.
Because of the way the commits are in main from the prisma merge I was unable to cherry-pick. Instead I did a merge from core. This means that git thinks there are commits going back almost 2 years that are a part of this change. So ignore the commits, but rather the actual changes.
Note:
How Can This Be Tested/Reviewed?
Both the partner and public sites should work e2e using the new backend.
Checklist:
yarn generate:client
and/or created a migration if I made backend changes that require themReviewer Notes:
Steps to review a PR:
On Merge:
If you have one commit and message, squash. If you need each message to be applied, rebase and merge.