Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Issue Overview
This PR addresses bloom-housing#3780 but now in HBA!
Description
This PR updates the application redirect to address the case where user's applied to a draft listing. There is also some custom handling included to preserve the preview listing functionality for partner's users. While we had a preview prop on the ListingView component to disable the apply online button, that prop has not been used for at least 18 months. This means that partners have been able to look through their application in the preview stage for a while now. Considering this and talking with Sarah, I included changes to preserve this partner's ability while still blocking them or a malicious user from submitting an application.
How Can This Be Tested/Reviewed?
This can be tested locally by finding the id of a draft listing, finding its public detail page via url, and seeing that the apply online button is disabled. Then go to the partner's page of the draft listing, hit preview, and try to go through the application flow from there. You will be redirected right before submission.
Checklist:
yarn generate:client
and/or created a migration if I made backend changes that require themReviewer Notes:
Steps to review a PR:
On Merge:
If you have one commit and message, squash. If you need each message to be applied, rebase and merge.