Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated application checks #656

Merged
merged 2 commits into from
Jan 4, 2024
Merged

Conversation

ColinBuyck
Copy link
Collaborator

@ColinBuyck ColinBuyck commented Jan 3, 2024

Pull Request Template

Issue Overview

This PR addresses bloom-housing#3780 but now in HBA!

  • This change addresses the issue in full
  • This change addresses only certain aspects of the issue
  • This change is a dependency for another issue
  • This change has a dependency from another issue

Description

This PR updates the application redirect to address the case where user's applied to a draft listing. There is also some custom handling included to preserve the preview listing functionality for partner's users. While we had a preview prop on the ListingView component to disable the apply online button, that prop has not been used for at least 18 months. This means that partners have been able to look through their application in the preview stage for a while now. Considering this and talking with Sarah, I included changes to preserve this partner's ability while still blocking them or a malicious user from submitting an application.

How Can This Be Tested/Reviewed?

This can be tested locally by finding the id of a draft listing, finding its public detail page via url, and seeing that the apply online button is disabled. Then go to the partner's page of the draft listing, hit preview, and try to go through the application flow from there. You will be redirected right before submission.

Checklist:

  • My code follows the style guidelines of this project
  • I have added QA notes to the issue with applicable URLs
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have run yarn generate:client and/or created a migration if I made backend changes that require them
  • My commit message(s) is/are polished, and any breaking changes are indicated in the message and are well-described
  • Commits made across packages purposefully have the same commit message/version change, else are separated into different commits

Reviewer Notes:

Steps to review a PR:

  • Read and understand the issue, and ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Also review the acceptance criteria on the Netlify deploy preview (noting that these do not yet include any backend changes made in the PR)
  • Either explicitly ask a clarifying question, request changes, or approve the PR if there are small remaining changes but the PR is otherwise good to go

On Merge:

If you have one commit and message, squash. If you need each message to be applied, rebase and merge.

Copy link

netlify bot commented Jan 3, 2024

Deploy Preview for housing-sanjoseca-gov ready!

Name Link
🔨 Latest commit e398c77
🔍 Latest deploy log https://app.netlify.com/sites/housing-sanjoseca-gov/deploys/6595cceb172bba000835e55d
😎 Deploy Preview https://deploy-preview-656--housing-sanjoseca-gov.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ColinBuyck ColinBuyck marked this pull request as ready for review January 3, 2024 21:20
@ColinBuyck ColinBuyck merged commit 70afb70 into main Jan 4, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants