Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release/2023 10 24 #649

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Release/2023 10 24 #649

merged 2 commits into from
Oct 27, 2023

Conversation

ColinBuyck
Copy link
Collaborator

@ColinBuyck ColinBuyck commented Oct 24, 2023 •
edited
Loading

Pull Request Template

Description

How Can This Be Tested/Reviewed?

Ensure this runs locally and correctly alphabetizes the listings that new users can be assigned to.

Checklist:

  • My code follows the style guidelines of this project
  • I have added QA notes to the issue with applicable URLs
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have run yarn generate:client and/or created a migration if I made backend changes that require them
  • My commit message(s) is/are polished, and any breaking changes are indicated in the message and are well-described
  • Commits made across packages purposefully have the same commit message/version change, else are separated into different commits

Reviewer Notes:

Steps to review a PR:

  • Read and understand the issue, and ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Also review the acceptance criteria on the Netlify deploy preview (noting that these do not yet include any backend changes made in the PR)
  • Either explicitly ask a clarifying question, request changes, or approve the PR if there are small remaining changes but the PR is otherwise good to go

On Merge:

If you have one commit and message, squash. If you need each message to be applied, rebase and merge.

ColinBuyck and others added 2 commits October 24, 2023 13:39
@ColinBuyck
fix: alphabetical listing order (bloom-housing#3678)
c79afbf
@dependabot @ColinBuyck
chore(deps): bump @babel/traverse from 7.21.2 to 7.23.2 (bloom-housin…
19a4388 
…g#3685)

Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.21.2 to 7.23.2.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse)

---
updated-dependencies:
- dependency-name: "@babel/traverse"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@ColinBuyck ColinBuyck marked this pull request as ready for review October 24, 2023 20:45
@netlify
Copy link

netlify bot commented Oct 24, 2023 •
edited
Loading

✅ Deploy Preview for housing-sanjoseca-gov ready!

Name Link
🔨 Latest commit 19a4388
🔍 Latest deploy log https://app.netlify.com/sites/housing-sanjoseca-gov/deploys/65382bfdaf367a00082af122
😎 Deploy Preview https://deploy-preview-649--housing-sanjoseca-gov.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ColinBuyck ColinBuyck merged commit c9004fb into main Oct 27, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludtkemorgan ludtkemorgan ludtkemorgan approved these changes

Assignees
No one assigned
Labels
ready to merge
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ColinBuyck @ludtkemorgan