feat: new hopwa program #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for hba-public-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for hba-partners-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
seanmalbert
reviewed
Jul 27, 2022
| @@ -330,7 +336,7 @@ const FormSummaryDetails = ({ | |||
| ))} | |||
| </ViewItem> | |||
| {application.programs | |||
| .filter((item) => item.claimed === true) | |||
| .filter((item: ApplicationProgram) => item.claimed === true && item.key !== "HOPWA") | |||
There was a problem hiding this comment.
@emilyjablonski , I don't like this, but I'm ok with it since we're overhauling preferences/programs now. Are we handling cases like this with the new setup?
There was a problem hiding this comment.
Same, in the new form we do have an explicit "hide" check
seanmalbert
approved these changes
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#448
Test by reseeding on dev and then just running the migration on this branch
(New issue to investigate why just reseeding on this branch doesn't work)
Add a new Alameda listing with the program. Submit an application to that listing and checkout the public side. Review the application on the partners app form.
This PR also additionally hides the program from the app summary component