chore: remove unused email logic (bloom-housing#4526)

* chore: remove unused email logic 4517 * chore: fold in getMismatchedJurisdictions 4517
housingbayarea · Jan 8, 2025 · 1e0ce30 · 1e0ce30
1 parent af63e3d
commit 1e0ce30
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 73 deletions.
diff --git a/api/src/services/email.service.ts b/api/src/services/email.service.ts
@@ -237,29 +237,6 @@ export class EmailService {
     );
   }
 
-  /* send account update email */
-  async portalAccountUpdate(
-    jurisdictionIds: IdDTO[],
-    user: User,
-    appUrl: string,
-  ) {
-    const jurisdiction = await this.getJurisdiction(jurisdictionIds);
-    void (await this.loadTranslations(jurisdiction, user.language));
-    const emailFromAddress = await this.getEmailToSendFrom(
-      jurisdictionIds,
-      jurisdiction,
-    );
-    await this.send(
-      user.email,
-      emailFromAddress,
-      this.polyglot.t('invite.portalAccountUpdate'),
-      this.template('portal-account-update')({
-        user,
-        appUrl,
-      }),
-    );
-  }
-
   /* send change of email email */
   public async changeEmail(
     jurisdictionName: string,

diff --git a/api/src/services/user.service.ts b/api/src/services/user.service.ts
@@ -717,25 +717,6 @@ export class UserService {
           confirmationUrl,
         );
       }
-
-      // Partner user that is given access to an additional jurisdiction
-    } else if (
-      forPartners &&
-      existingUser &&
-      'userRoles' in dto &&
-      existingUser?.userRoles?.isPartner &&
-      dto?.userRoles?.isPartner &&
-      this.jurisdictionMismatch(dto.jurisdictions, existingUser.jurisdictions)
-    ) {
-      const newJurisdictions = this.getMismatchedJurisdictions(
-        dto.jurisdictions,
-        existingUser.jurisdictions,
-      );
-      this.emailService.portalAccountUpdate(
-        newJurisdictions,
-        mapTo(User, newUser),
-        dto.appUrl,
-      );
     } else if (forPartners) {
       const confirmationUrl = this.getPartnersConfirmationUrl(
         this.configService.get('PARTNERS_PORTAL_URL'),
@@ -896,29 +877,19 @@ export class UserService {
     existingJurisdictions: IdDTO[],
   ): boolean {
     return (
-      this.getMismatchedJurisdictions(
-        incomingJurisdictions,
-        existingJurisdictions,
-      ).length > 0
+      incomingJurisdictions.reduce((misMatched, jurisdiction) => {
+        if (
+          !existingJurisdictions?.some(
+            (existingJuris) => existingJuris.id === jurisdiction.id,
+          )
+        ) {
+          misMatched.push(jurisdiction.id);
+        }
+        return misMatched;
+      }, []).length > 0
     );
   }
 
-  getMismatchedJurisdictions(
-    incomingJurisdictions: IdDTO[],
-    existingJurisdictions: IdDTO[],
-  ) {
-    return incomingJurisdictions.reduce((misMatched, jurisdiction) => {
-      if (
-        !existingJurisdictions?.some(
-          (existingJuris) => existingJuris.id === jurisdiction.id,
-        )
-      ) {
-        misMatched.push(jurisdiction.id);
-      }
-      return misMatched;
-    }, []);
-  }
-
   containsInvalidCharacters(value: string): boolean {
     return value.includes('.') || value.includes('http');
   }

diff --git a/api/src/views/portal-account-update.hbs b/api/src/views/portal-account-update.hbs