Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace references to "rake" with "bin/rails" #1070

Merged
merged 1 commit into from
Mar 25, 2022

Conversation

BenSturmfels
Copy link
Contributor

In #1060, @wwahammy mentioned in #1060 (comment) that this is recommended approach as of ~ Rails 6.

I've confirmed that:

  • bin/webpack and bin/webpack-dev-server still run
  • script/compile-assets.sh runs
  • script/db_total_reset.sh runs
  • JS tests still pass

I haven't tested:

  • Procfile.dev
  • script/crontab.sh (don't have rvm installed)

In houdiniproject#1060, @wwahammy mentioned that this is recommended approach as of ~ Rails 6.
@BenSturmfels BenSturmfels changed the title Replace references to "rake" with "bin/rails". Replace references to "rake" with "bin/rails" Mar 25, 2022
Copy link
Member

@wwahammy wwahammy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for the PR!

@wwahammy wwahammy merged commit 9089e79 into houdiniproject:main Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants